Expose workerCount as constructor parameter in StaticTcpProxyConfig
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes issue terma#7 Use cases which do not rely on parsing properties file tend to repeat the same pattern to first create an instance of StaticTcpProxyConfig and then immediately set the number of workers. To make the code more user-friendly the `workerCount` is exposed as a constructor parameter.
|
Nice, thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #7
Use cases which do not rely on parsing properties file tend to repeat
the same pattern to first create an instance of
StaticTcpProxyConfigandthen immediately set the number of workers.
To make the code more user-friendly the
workerCountis exposed as aconstructor parameter.