Fix at-rule pattern warnings to range only one line #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nlydv Thanks a lot! Could you please also update the unit tests to verify that the change is working? I think that you should be able to assert the |
|
Done! |
|
@nlydv Thanks! Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first contrib here.
I noticed the
at-function-patternandat-mixin-patternrules spit out warnings with a range over the entire at-rule block as the "problem area", which of course doesn't make sense when it's just the name that's the issue.Not at all familiar with the codebase and I just wanted to slap a quick fix on it if I could, best I was able to do was limiting it to one line only.
Before:
After:
