Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta property for all rules #602

Merged
merged 3 commits into from
May 27, 2022
Merged

Add meta property for all rules #602

merged 3 commits into from
May 27, 2022

Conversation

ybiquitous
Copy link
Contributor

@ybiquitous ybiquitous commented May 9, 2022

Each rule function should have properties like ruleName.
See https://stylelint.io/developer-guide/plugins

For example, stylelint -f verbose command can show rules' links:

image

Each rule function should have properties like `ruleName`.
See https://stylelint.io/developer-guide/plugins
@ybiquitous ybiquitous marked this pull request as ready for review May 9, 2022 15:24
@@ -0,0 +1,15 @@
const revision = "master";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] If using a tag (e.g. v4.2.0), the implementation would be more complex. I think the HEAD version (master) is enough.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using master sounds good enough.

@kristerkari
Copy link
Collaborator

Thanks! I'll try to get this reviewed ASAP.

Copy link
Collaborator

@kristerkari kristerkari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good 👍

@kristerkari kristerkari merged commit 1c65d3c into stylelint-scss:master May 27, 2022
@ybiquitous ybiquitous deleted the add-meta-property branch May 29, 2022 00:04
@ybiquitous
Copy link
Contributor Author

@kristerkari Thank you for the review and merge! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants