Implement the at-use-no-unnamespaced rule #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My implementation is incomplete. It won't catch configured modules, as the configuration comes after the namespace in the rule. |
stof
force-pushed
the
rule_use_no_unnamespaced
branch
from
2a25f2b to
349e574
Compare
|
And here is the complete implementation |
kristerkari
reviewed
Dec 2, 2021
| export const ruleName = namespace("at-use-no-unnamespaced"); | ||
|
|
||
| export const messages = utils.ruleMessages(ruleName, { | ||
| expected: "Expected @use to use a namespace" |
There was a problem hiding this comment.
I went and checked from the stylelint repo, and most of the -no- rules seem to use the rejected: "Unexpected ..." message format, should this rule also use it?
stof
force-pushed
the
rule_use_no_unnamespaced
branch
from
349e574 to
98103ec
Compare
kristerkari
approved these changes
Dec 8, 2021
|
This was released in 4.1.0: Thank you @stof ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #565