fix: use processSync #567
Merged
fix: use processSync #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
anyone come to review this? |
kristerkari
reviewed
Nov 29, 2021
src/utils/parseSelector.js
Outdated
| @@ -2,7 +2,7 @@ import postCssSelectorParser from "postcss-selector-parser"; | |||
|
|
|||
| export default function(selector, result, node, cb) { | |||
| try { | |||
| postCssSelectorParser(cb).process(selector); | |||
| postCssSelectorParser(cb).processSync(selector); | |||
There was a problem hiding this comment.
We could make this fully match the code from stylelint and make add a return: return postCssSelectorParser(cb).processSync(selector)
There was a problem hiding this comment.
Sorry for late response.
I was working on an old version of stylelint, in which I see no return in the source code.
I read the latest code of stylelint again. I see the return there. My PR is Updated.
There was a problem hiding this comment.
For convenience, I post the source code url here
https://github.com/stylelint/stylelint/blob/main/lib/utils/parseSelector.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the Stylelint source code, it use processSync.
process() returns a Promise but it's not handled properly.