Allow using the CSS min and max calculations and the CSS filter functions #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristerkari
approved these changes
Nov 29, 2021
|
@stof could you please also add unit tests for this change? |
The Sass functions should indeed be migrated to the sass:math module. But min() and max() can also be the CSS functions (and with first-class calc in Sass, it will parse it as a calculation if possible).
The Sass function shadows a CSS function. The global name should still be allowed when using the CSS function. A more complete change might be to allow only global usages that pass a number as the only argument, but this is more complex to implement (especially when the argument comes from a Sass variable that might be a number or no).
|
@kristerkari done. and I also solved the case of |
stof
changed the title
stof
changed the title
|
@stof looks like some unit tests are failing |
|
@kristerkari fixed |
|
Thanks for the contribution @stof �! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Sass functions should indeed be migrated to the sass:math module. But min() and max() can also be the CSS functions (and with first-class calc in Sass, it will parse it as a calculation if possible).
Closes #560
Closes #562
Closes #486