Add messageArgs to declaration-property-value-no-unknown, font-family-name-quotes, font-family-no-duplicate-names, function-calc-no-unspaced-operator, import-notation and selector-attribute-quotes
#8285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 40449b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Mouvedia
commented
Jan 6, 2025
docs/user-guide/configure.md
Outdated
There was a problem hiding this comment.
messageArgs has been added to all the rules that may use it.
i.e. either has one type of message or both types use the same argument
This PR doesn't close #6966 though.
Mouvedia
force-pushed
the
mouvedia-crm-5
branch
from
cf6b9b2 to
0e5a17b
Compare
Mouvedia
commented
Jan 6, 2025
Mouvedia
changed the title
messageArgs to font-family-name-quotes, font-family-no-duplicate-names, function-url-quotes, import-notation and selector-attribute-quotesmessageArgs to declaration-property-value-no-unknown, font-family-name-quotes, font-family-no-duplicate-names, function-calc-no-unspaced-operator, function-url-quotes, import-notation and selector-attribute-quotes
Mouvedia
force-pushed
the
mouvedia-crm-5
branch
2 times, most recently
from
df5385c to
7849bb7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
…amily-name-quotes`, `font-family-no-duplicate-names`, `function-calc-no-unspaced-operator`, `function-url-quotes`, `import-notation` and `selector-attribute-quotes`
Mouvedia
force-pushed
the
mouvedia-crm-5
branch
from
7849bb7 to
b6a5205
Compare
ybiquitous
reviewed
Jan 7, 2025
Mouvedia
commented
Jan 7, 2025
|
@Mouvedia I'm afraid, but as I have told you multiple times, it seems you often include more things than a PR title says. I think this PR contains more than what the title "Add In general, when a PR has many things, it becomes hard to track the commit history or why a change was performed. |
Ill remove the consistency message enhancements for
Ill keep the removal of
I do when it's tightly related and considered a minor enhancement/refactor. |
revert message updates of rules `no-duplicate-at-import-rules`, `declaration-block-no-duplicate-properties`, `declaration-block-no-duplicate-custom-properties` and `keyframe-block-no-duplicate-selectors`
ybiquitous
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Ill keep the removal of declaration-property-value-keyword-no-deprecated's messageArgs because the goal of this PR is to pave the way for the type PR. Before the release of 16.13.0 it's a refactor and doesn't impact anything.
Okay 👍🏼
I do when it's tightly related and considered a minor enhancement/refactor.
Please keep in mind my comment above when you do so. You often create a pretty big PR.
Mouvedia
force-pushed
the
mouvedia-crm-5
branch
from
6243f72 to
b63cb91
Compare
Mouvedia
force-pushed
the
mouvedia-crm-5
branch
from
b63cb91 to
40449b0
Compare
Mouvedia
changed the title
messageArgs to declaration-property-value-no-unknown, font-family-name-quotes, font-family-no-duplicate-names, function-calc-no-unspaced-operator, function-url-quotes, import-notation and selector-attribute-quotesmessageArgs to declaration-property-value-no-unknown, font-family-name-quotes, font-family-no-duplicate-names, function-calc-no-unspaced-operator, import-notation and selector-attribute-quotes
ybiquitous
approved these changes
Jan 7, 2025
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 12, 2025
| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.12.0 | 16.13.0 | ## [v16.13.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16130---2025-01-12) It adds 3 rules to help you write error-free at-rules and 2 rules to warn you about deprecated CSS features. We've turned these rules on in our [standard config](https://www.npmjs.com/package/stylelint-config-standard). It also adds new rule options, a feature to display how long rules take, lax autofix and support for `messageArgs` in more rules. It fixes 7 bugs. Lastly, we've made a deprecation that may affect some plugins. We've updated our docs for [plugin authors](docs/developer-guide/plugins.md#quiet-deprecation-warnings) and [end users](docs/user-guide/options.md#quietdeprecationwarnings) on how to silence deprecation warnings. - Deprecated: ambiguous position arguments passed to `utils.report()` ([#8244](stylelint/stylelint#8244)) ([@romainmenke](https://github.com/romainmenke)). - Added: `lax`/`strict` values to the `fix` Node.js API option and CLI flag ([#8106](stylelint/stylelint#8106)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: support for profiling rule performance via the `TIMING` environment variable ([#8108](stylelint/stylelint#8108)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `at-rule-descriptor-no-unknown` rule ([#8197](stylelint/stylelint#8197)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `at-rule-descriptor-value-no-unknown` rule ([#8211](stylelint/stylelint#8211)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `at-rule-no-deprecated` rule ([#8251](stylelint/stylelint#8251)) ([@jeddy3](https://github.com/jeddy3)). - Added: `at-rule-prelude-no-invalid` rule ([#8268](stylelint/stylelint#8268)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `declaration-property-value-keyword-no-deprecated` rule ([#8223](stylelint/stylelint#8223)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `"ignore": ["at-rule-preludes", "declaration-values"]` to `string-no-newline` ([#8214](stylelint/stylelint#8214)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `messageArgs` to `declaration-property-value-no-unknown`, `font-family-name-quotes`, `font-family-no-duplicate-names`, `function-calc-no-unspaced-operator`, `import-notation`, `media-feature-name-unit-allowed-list`, `selector-attribute-quotes` and `selector-pseudo-element-colon-notation` ([#8285](stylelint/stylelint#8285) & [#8252](stylelint/stylelint#8252)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: deprecation warnings to only display once per (custom) rule ([#8265](stylelint/stylelint#8265)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `*-no-vendor-prefix` message ambiguity ([#8239](stylelint/stylelint#8239)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `at-rule-(dis)allowed-list`, `at-rule-no-vendor-prefix`, `at-rule-property-required-list` message argument ([#8277](stylelint/stylelint#8277)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `at-rule-property-required-list` message for inclusion of properties and descriptors ([#8207](stylelint/stylelint#8207)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `at-rule-*` false positives and negatives for `@charset` rule ([#8215](stylelint/stylelint#8215)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `declaration-property-value-no-unknown` false positives for descriptors ([#8240](stylelint/stylelint#8240)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `property-(dis)allowed-list` false negatives for custom properties, use `/^--/` to (dis)allow them ([#8209](stylelint/stylelint#8209)) ([@fbasmaison-lucca](https://github.com/fbasmaison-lucca)). - Fixed: `property-no-unknown` false positives for descriptors ([#8203](stylelint/stylelint#8203)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `selector-pseudo-class-no-unknown` false positives for deprecated pseudo-classes ([#8264](stylelint/stylelint#8264)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-type-case` false positives for `hatchPath` ([#8264](stylelint/stylelint#8264)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-type-no-unknown` false positives for `shadow`, `hatch` and `hatchpath` ([#8264](stylelint/stylelint#8264)) ([@Mouvedia](https://github.com/Mouvedia)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4117
#6966
function-url-quotesdidn't passmessageArgstoreporthence the argument replacement is a refactor.see #8285 (comment)
I could add
messageArgstonamed-grid-areas-no-invalidbut I consider it not future-proof.i.e. Ill postpone until #8134 has been fixed