Fixed selector|value-no-vendor-prefix performance #7016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6a918a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ybiquitous
reviewed
Jun 30, 2023
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
ybiquitous
reviewed
Jun 30, 2023
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Mouvedia
reviewed
Jun 30, 2023
| @@ -0,0 +1,5 @@ | |||
| const prefixes = new Set(['-webkit-', '-moz-', '-ms-', '-o-']); | |||
There was a problem hiding this comment.
If this is to be reused, Ill eventually add some more rare ones to the set.
ref: https://stackoverflow.com/questions/11705144/webkit-and-its-legacy-prefixes
Mouvedia
reviewed
Jun 30, 2023
| !isStandardSyntaxProperty(decl.prop) || | ||
| !value.startsWith('-') | ||
| ) { | ||
| if (!hasPrefix(value)) return; |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6869
selector-no-vendor-prefix
Mean: 246.52507291666666 ms
Deviation: 22.75678614753106 ms
To
Mean: 91.62227779999999 ms
Deviation: 7.8451629248369095 ms
value-no-vendor-prefix
Mean: 102.0994388 ms
Deviation: 11.78154094781758 ms
To
Mean: 91.27013606666667 ms
Deviation: 15.351019516794766 ms