Fix `selector-pseudo-class-no-unknown` false positives for some `moz-*` vendor-prefixed pseudo-classes #8188

Mouvedia · 2024-12-13T01:29:05Z

Which issue, if any, is this issue related to?

N/A

Is there anything in the PR that needs further explanation?

https://bugzilla.mozilla.org/show_bug.cgi?id=309067
https://bugzilla.mozilla.org/show_bug.cgi?id=71261
https://bugzilla.mozilla.org/show_bug.cgi?id=1839221
https://developer.mozilla.org/en-US/docs/Web/CSS/:dir
https://developer.mozilla.org/en-US/docs/Web/CSS/:read-only
https://developer.mozilla.org/en-US/docs/Web/CSS/:read-write

changeset-bot · 2024-12-13T01:29:09Z

🦋 Changeset detected

Latest commit: 77a9832

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
stylelint	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Mouvedia · 2024-12-13T01:37:47Z

lib/reference/selectors.mjs

 	'-moz-submit-invalid',
 	'-moz-suppressed',
+	'-moz-table-border-nonzero',


[border]:not([border="0"])

ybiquitous · 2024-12-13T09:09:06Z

@Mouvedia I'd appreciate making bugfix PRs. But I was hoping you could create a dedicated PR so we can easily review a PR and track the commit history unless there is no special reason. I believe it's not a good sign that one PR includes multiple changelog items.

~~For an example of value-no-vendor-prefix, we could see the Demo to reproduce the bug and helpful resources, such as MDN links.~~

Mouvedia · 2024-12-13T09:13:21Z

I was hoping you could create a dedicated PR

Ill split it in two when Ill have time.

Mouvedia · 2024-12-13T20:11:08Z

.changeset/dirty-fishes-approve.md

has the same author
i.e. me

jeddy3

One minor suggestion to add some details to the changelog entry, otherwise LGTM thank you.

.changeset/thin-buses-greet.md

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>

jeddy3

LGTM, thank you!

@Mouvedia

| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.11.0 | 16.12.0 | ## [v16.12.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16120) - Added: `selector-pseudo-class-allowed-list` now checks `@page` pseudo-classes ([#8176](stylelint/stylelint#8176)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `selector-pseudo-class-disallowed-list` now checks `@page` pseudo-classes ([#8171](stylelint/stylelint#8171)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `at-rule-property-required-list` message to use "descriptor" for accuracy ([#8186](stylelint/stylelint#8186)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: `custom-property-no-missing-var-function` false positives for `container-name` ([#8157](stylelint/stylelint#8157)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `custom-property-no-missing-var-function` false positives for custom properties passed to `running()` ([#8172](stylelint/stylelint#8172)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `function-no-unknown` false positives for `running()` ([#8172](stylelint/stylelint#8172)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-class-no-unknown` false positives for `:open` ([#8184](stylelint/stylelint#8184)) ([@lukewarlow](https://github.com/lukewarlow)). - Fixed: `selector-pseudo-class-no-unknown` false positives for `:recto`, `:verso` and `:nth()` ([#8170](stylelint/stylelint#8170)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-class-no-unknown` false positives for some `moz-*` vendor-prefixed pseudo-classes ([#8188](stylelint/stylelint#8188)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-element-no-unknown` false positives for `::details-content` ([#8174](stylelint/stylelint#8174)) ([@lukewarlow](https://github.com/lukewarlow)). - Fixed: `selector-type-no-unknown` false positives for idents in functional pseudo-classes ([#8191](stylelint/stylelint#8191)) ([@elskhn](https://github.com/elskhn)). - Fixed: `value-keyword-case` false negatives ([#8158](stylelint/stylelint#8158)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `value-keyword-case` false positives for vendor-prefixed system colors ([#8146](stylelint/stylelint#8146)) ([@Mouvedia](https://github.com/Mouvedia)).

@Mouvedia

| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.11.0 | 16.12.0 | ## [v16.12.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16120) - Added: `selector-pseudo-class-allowed-list` now checks `@page` pseudo-classes ([#8176](stylelint/stylelint#8176)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `selector-pseudo-class-disallowed-list` now checks `@page` pseudo-classes ([#8171](stylelint/stylelint#8171)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `at-rule-property-required-list` message to use "descriptor" for accuracy ([#8186](stylelint/stylelint#8186)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: `custom-property-no-missing-var-function` false positives for `container-name` ([#8157](stylelint/stylelint#8157)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `custom-property-no-missing-var-function` false positives for custom properties passed to `running()` ([#8172](stylelint/stylelint#8172)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `function-no-unknown` false positives for `running()` ([#8172](stylelint/stylelint#8172)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-class-no-unknown` false positives for `:open` ([#8184](stylelint/stylelint#8184)) ([@lukewarlow](https://github.com/lukewarlow)). - Fixed: `selector-pseudo-class-no-unknown` false positives for `:recto`, `:verso` and `:nth()` ([#8170](stylelint/stylelint#8170)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-class-no-unknown` false positives for some `moz-*` vendor-prefixed pseudo-classes ([#8188](stylelint/stylelint#8188)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-element-no-unknown` false positives for `::details-content` ([#8174](stylelint/stylelint#8174)) ([@lukewarlow](https://github.com/lukewarlow)). - Fixed: `selector-type-no-unknown` false positives for idents in functional pseudo-classes ([#8191](stylelint/stylelint#8191)) ([@elskhn](https://github.com/elskhn)). - Fixed: `value-keyword-case` false negatives ([#8158](stylelint/stylelint#8158)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `value-keyword-case` false positives for vendor-prefixed system colors ([#8146](stylelint/stylelint#8146)) ([@Mouvedia](https://github.com/Mouvedia)).

@Mouvedia

| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.11.0 | 16.12.0 | ## [v16.12.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16120) - Added: `selector-pseudo-class-allowed-list` now checks `@page` pseudo-classes ([#8176](stylelint/stylelint#8176)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `selector-pseudo-class-disallowed-list` now checks `@page` pseudo-classes ([#8171](stylelint/stylelint#8171)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `at-rule-property-required-list` message to use "descriptor" for accuracy ([#8186](stylelint/stylelint#8186)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: `custom-property-no-missing-var-function` false positives for `container-name` ([#8157](stylelint/stylelint#8157)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `custom-property-no-missing-var-function` false positives for custom properties passed to `running()` ([#8172](stylelint/stylelint#8172)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `function-no-unknown` false positives for `running()` ([#8172](stylelint/stylelint#8172)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-class-no-unknown` false positives for `:open` ([#8184](stylelint/stylelint#8184)) ([@lukewarlow](https://github.com/lukewarlow)). - Fixed: `selector-pseudo-class-no-unknown` false positives for `:recto`, `:verso` and `:nth()` ([#8170](stylelint/stylelint#8170)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-class-no-unknown` false positives for some `moz-*` vendor-prefixed pseudo-classes ([#8188](stylelint/stylelint#8188)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-element-no-unknown` false positives for `::details-content` ([#8174](stylelint/stylelint#8174)) ([@lukewarlow](https://github.com/lukewarlow)). - Fixed: `selector-type-no-unknown` false positives for idents in functional pseudo-classes ([#8191](stylelint/stylelint#8191)) ([@elskhn](https://github.com/elskhn)). - Fixed: `value-keyword-case` false negatives ([#8158](stylelint/stylelint#8158)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `value-keyword-case` false positives for vendor-prefixed system colors ([#8146](stylelint/stylelint#8146)) ([@Mouvedia](https://github.com/Mouvedia)).

@Mouvedia

| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.11.0 | 16.12.0 | ## [v16.12.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16120) - Added: `selector-pseudo-class-allowed-list` now checks `@page` pseudo-classes ([#8176](stylelint/stylelint#8176)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `selector-pseudo-class-disallowed-list` now checks `@page` pseudo-classes ([#8171](stylelint/stylelint#8171)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `at-rule-property-required-list` message to use "descriptor" for accuracy ([#8186](stylelint/stylelint#8186)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: `custom-property-no-missing-var-function` false positives for `container-name` ([#8157](stylelint/stylelint#8157)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `custom-property-no-missing-var-function` false positives for custom properties passed to `running()` ([#8172](stylelint/stylelint#8172)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `function-no-unknown` false positives for `running()` ([#8172](stylelint/stylelint#8172)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-class-no-unknown` false positives for `:open` ([#8184](stylelint/stylelint#8184)) ([@lukewarlow](https://github.com/lukewarlow)). - Fixed: `selector-pseudo-class-no-unknown` false positives for `:recto`, `:verso` and `:nth()` ([#8170](stylelint/stylelint#8170)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-class-no-unknown` false positives for some `moz-*` vendor-prefixed pseudo-classes ([#8188](stylelint/stylelint#8188)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-element-no-unknown` false positives for `::details-content` ([#8174](stylelint/stylelint#8174)) ([@lukewarlow](https://github.com/lukewarlow)). - Fixed: `selector-type-no-unknown` false positives for idents in functional pseudo-classes ([#8191](stylelint/stylelint#8191)) ([@elskhn](https://github.com/elskhn)). - Fixed: `value-keyword-case` false negatives ([#8158](stylelint/stylelint#8158)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `value-keyword-case` false positives for vendor-prefixed system colors ([#8146](stylelint/stylelint#8146)) ([@Mouvedia](https://github.com/Mouvedia)).

@Mouvedia

| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.11.0 | 16.12.0 | ## [v16.12.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16120) - Added: `selector-pseudo-class-allowed-list` now checks `@page` pseudo-classes ([#8176](stylelint/stylelint#8176)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `selector-pseudo-class-disallowed-list` now checks `@page` pseudo-classes ([#8171](stylelint/stylelint#8171)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `at-rule-property-required-list` message to use "descriptor" for accuracy ([#8186](stylelint/stylelint#8186)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: `custom-property-no-missing-var-function` false positives for `container-name` ([#8157](stylelint/stylelint#8157)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `custom-property-no-missing-var-function` false positives for custom properties passed to `running()` ([#8172](stylelint/stylelint#8172)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `function-no-unknown` false positives for `running()` ([#8172](stylelint/stylelint#8172)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-class-no-unknown` false positives for `:open` ([#8184](stylelint/stylelint#8184)) ([@lukewarlow](https://github.com/lukewarlow)). - Fixed: `selector-pseudo-class-no-unknown` false positives for `:recto`, `:verso` and `:nth()` ([#8170](stylelint/stylelint#8170)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-class-no-unknown` false positives for some `moz-*` vendor-prefixed pseudo-classes ([#8188](stylelint/stylelint#8188)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-element-no-unknown` false positives for `::details-content` ([#8174](stylelint/stylelint#8174)) ([@lukewarlow](https://github.com/lukewarlow)). - Fixed: `selector-type-no-unknown` false positives for idents in functional pseudo-classes ([#8191](stylelint/stylelint#8191)) ([@elskhn](https://github.com/elskhn)). - Fixed: `value-keyword-case` false negatives ([#8158](stylelint/stylelint#8158)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `value-keyword-case` false positives for vendor-prefixed system colors ([#8146](stylelint/stylelint#8146)) ([@Mouvedia](https://github.com/Mouvedia)).

Mouvedia force-pushed the fix-moz-pc+val branch from a9e47bb to 7afa89e Compare December 13, 2024 01:34

Mouvedia commented Dec 13, 2024

View reviewed changes

Mouvedia marked this pull request as ready for review December 13, 2024 01:39

Mouvedia requested a review from ybiquitous December 13, 2024 01:45

Mouvedia force-pushed the fix-moz-pc+val branch from e6d2351 to 595e4f7 Compare December 13, 2024 08:18

Mouvedia added 2 commits December 13, 2024 20:58

remove changeset

4a8a063

Add some missing vendor-prefixed pseudo-classes

432372d

Mouvedia force-pushed the fix-moz-pc+val branch from 595e4f7 to 432372d Compare December 13, 2024 20:02

Mouvedia changed the title ~~Add some missing vendor-prefixed pseudo-classes and values~~ Add some missing vendor-prefixed pseudo-classes Dec 13, 2024

Mouvedia commented Dec 13, 2024

View reviewed changes

.changeset/dirty-fishes-approve.md Outdated

Copy link

Member Author

Mouvedia Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has the same author
i.e. me

jeddy3 changed the title ~~Add some missing vendor-prefixed pseudo-classes~~ Fix selector-pseudo-class-no-unknown false positives for some moz-* vendor-prefixed pseudo-classes Dec 14, 2024

jeddy3 reviewed Dec 14, 2024

View reviewed changes

.changeset/thin-buses-greet.md Outdated Show resolved Hide resolved

Update .changeset/thin-buses-greet.md

77a9832

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>

jeddy3 approved these changes Dec 14, 2024

View reviewed changes

jeddy3 merged commit 6a3b170 into stylelint:main Dec 14, 2024
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `selector-pseudo-class-no-unknown` false positives for some `moz-*` vendor-prefixed pseudo-classes #8188

Fix `selector-pseudo-class-no-unknown` false positives for some `moz-*` vendor-prefixed pseudo-classes #8188

Mouvedia commented Dec 13, 2024 •

edited

Loading

changeset-bot bot commented Dec 13, 2024 •

edited

Loading

Mouvedia Dec 13, 2024

ybiquitous commented Dec 13, 2024 •

edited by Mouvedia

Loading

Mouvedia commented Dec 13, 2024

Mouvedia Dec 13, 2024

jeddy3 left a comment

jeddy3 left a comment

Fix selector-pseudo-class-no-unknown false positives for some moz-* vendor-prefixed pseudo-classes #8188

Fix selector-pseudo-class-no-unknown false positives for some moz-* vendor-prefixed pseudo-classes #8188

Conversation

Mouvedia commented Dec 13, 2024 • edited Loading

changeset-bot bot commented Dec 13, 2024 • edited Loading

🦋 Changeset detected

Mouvedia Dec 13, 2024

Choose a reason for hiding this comment

ybiquitous commented Dec 13, 2024 • edited by Mouvedia Loading

Mouvedia commented Dec 13, 2024

Mouvedia Dec 13, 2024

Choose a reason for hiding this comment

jeddy3 left a comment

Choose a reason for hiding this comment

jeddy3 left a comment

Choose a reason for hiding this comment

Fix `selector-pseudo-class-no-unknown` false positives for some `moz-*` vendor-prefixed pseudo-classes #8188

Fix `selector-pseudo-class-no-unknown` false positives for some `moz-*` vendor-prefixed pseudo-classes #8188

Mouvedia commented Dec 13, 2024 •

edited

Loading

changeset-bot bot commented Dec 13, 2024 •

edited

Loading

ybiquitous commented Dec 13, 2024 •

edited by Mouvedia

Loading