Fix `no-irregular-whitespace` reported ranges #8066

romainmenke · 2024-10-21T18:05:01Z

Which issue, if any, is this issue related to?

See #7904

Is there anything in the PR that needs further explanation?

No

changeset-bot · 2024-10-21T18:05:05Z

🦋 Changeset detected

Latest commit: fcf29c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
stylelint	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

romainmenke · 2024-10-21T18:06:14Z

lib/rules/no-irregular-whitespace/index.mjs

 /**
 * @param {string} str
- * @returns {string | null}
+ * @returns {Array<{index: number, length: number}>}
 */
 const findIrregularWhitespace = (str) => {
-	const result = IRREGULAR_WHITESPACES_PATTERN.exec(str);
-
-	return (result && result[1]) || null;
+	return Array.from(str.matchAll(IRREGULAR_WHITESPACES_PATTERN)).map((match) => {
+		return {
+			index: match.index,
+			length: match[0].length,
+		};
+	});
 };


The old implementation only reported a single irregular whitespace per AST field.
Instead of reporting each contiguous instance.

…-masked-palm-civet-aa54d96cf9' of https://github.com/stylelint/stylelint into fix-no-irregular-whitespace-reported-ranges--passionate-masked-palm-civet-aa54d96cf9

lib/utils/atRuleRawsAfterIndex.mjs

lib/utils/ruleRawsAfterIndex.mjs

lib/utils/__tests__/atRuleRawsAfterNameIndex.test.mjs

lib/rules/no-irregular-whitespace/index.mjs

…-passionate-masked-palm-civet-aa54d96cf9

lib/utils/atRuleParamIndex.mjs

This reverts commit db4ce62.

…-passionate-masked-palm-civet-aa54d96cf9

ybiquitous

[suggestion] Can you extract a few pull requests from this one to make reviewing/reverting easier?

For example, one PR for the declaration utils is fine to me.

For the declaration utils, does it make sense to combine them to one function? I imagine the interface would be:

/**
 * @param {import('postcss').Declaration} decl
 * @param {'between' | 'value'} component
 * @returns {number}
 */
export function declarationComponentIndex(decl, component) {
  // ...
}

I'd like to reduce similar files/codes for maintainability even if they're internal.

Mouvedia · 2024-11-12T09:29:55Z

I'd like to reduce similar files/codes for maintainability even if they're internal.

@ybiquitous see #8097.

…espace-reported-ranges--passionate-masked-palm-civet-aa54d96cf9

romainmenke · 2024-11-16T18:13:08Z

This should be ready for another look, thank you for the feedback

Mouvedia

Iv left some additional comments; nothing important though.

lib/rules/no-irregular-whitespace/__tests__/index.mjs

lib/rules/no-irregular-whitespace/index.cjs

ybiquitous

Thank you for your effort. The code is now much cleaner while fixing the bug! LGTM 😄 👍🏼

@Mouvedia

| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.10.0 | 16.11.0 | ## [v16.11.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16110) - Added: `--report-unscoped-disables` CLI flag and `reportUnscopedDisables` option to Node.js API and configuration object ([#8024](stylelint/stylelint#8024)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `ignoreFunctions: []` to `media-query-no-invalid` ([#8060](stylelint/stylelint#8060)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `name` configuration property under `overrides` ([#8095](stylelint/stylelint#8095)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `benchmark-rule` script to resolve `TypeError` ([#8090](stylelint/stylelint#8090)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: `github` formatter deprecation warning link to `https://stylelint.io/awesome-stylelint#formatters` ([#8115](stylelint/stylelint#8115)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `function-calc-no-unspaced-operator` false negatives for `calc-size` ([#8026](stylelint/stylelint#8026)) ([@azat-io](https://github.com/azat-io)). - Fixed: `max-nesting-depth` false positives when the `&` selector is being ignored ([#8048](stylelint/stylelint#8048)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `media-feature-name-value-no-unknown` false positives for `display-mode: picture-in-picture` ([#8136](stylelint/stylelint#8136)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `no-irregular-whitespace` reported ranges ([#8066](stylelint/stylelint#8066)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `selector-attribute-name-disallowed-list` reported ranges ([#8037](stylelint/stylelint#8037)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-attribute-operator-allowed-list` reported ranges ([#8038](stylelint/stylelint#8038)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-attribute-operator-disallowed-list` reported ranges ([#8039](stylelint/stylelint#8039)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-class-pattern` reported ranges ([#8042](stylelint/stylelint#8042)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-combinator-allowed-list` reported ranges ([#8046](stylelint/stylelint#8046)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-combinator-disallowed-list` reported ranges ([#8047](stylelint/stylelint#8047)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-disallowed-list` reported ranges ([#8067](stylelint/stylelint#8067)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-id-pattern` reported ranges ([#8045](stylelint/stylelint#8045)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-attribute` reported ranges ([#8052](stylelint/stylelint#8052)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-class` reported ranges ([#8053](stylelint/stylelint#8053)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-combinators` reported-ranges ([#8055](stylelint/stylelint#8055)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-compound-selectors` reported ranges ([#8056](stylelint/stylelint#8056)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-id` reported ranges ([#8054](stylelint/stylelint#8054)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-pseudo-class` reported ranges ([#8057](stylelint/stylelint#8057)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-specificity` reported ranges ([#8058](stylelint/stylelint#8058)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-universal` reported ranges ([#8059](stylelint/stylelint#8059)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-nested-pattern` reported ranges ([#8072](stylelint/stylelint#8072)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-no-vendor-prefix` reported ranges ([#8073](stylelint/stylelint#8073)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-not-notation` reported ranges ([#8074](stylelint/stylelint#8074)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-class-allowed-list` reported ranges ([#8061](stylelint/stylelint#8061)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-class-disallowed-list` reported ranges ([#8062](stylelint/stylelint#8062)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-class-no-unknown` reported ranges ([#8063](stylelint/stylelint#8063)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-element-allowed-list` reported ranges ([#8068](stylelint/stylelint#8068)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-element-colon-notation` reported ranges ([#8069](stylelint/stylelint#8069)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-element-disallowed-list` reported ranges ([#8070](stylelint/stylelint#8070)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-element-no-unknown` false positives for `::scroll-marker` and `::scroll-marker-group` ([#8110](stylelint/stylelint#8110)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-element-no-unknown` reported ranges ([#8071](stylelint/stylelint#8071)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-type-no-unknown` reported ranges ([#8076](stylelint/stylelint#8076)) ([@ryo-manba](https://github.com/ryo-manba)).

@Mouvedia

| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.10.0 | 16.11.0 | ## [v16.11.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16110) - Added: `--report-unscoped-disables` CLI flag and `reportUnscopedDisables` option to Node.js API and configuration object ([#8024](stylelint/stylelint#8024)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `ignoreFunctions: []` to `media-query-no-invalid` ([#8060](stylelint/stylelint#8060)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `name` configuration property under `overrides` ([#8095](stylelint/stylelint#8095)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `benchmark-rule` script to resolve `TypeError` ([#8090](stylelint/stylelint#8090)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: `github` formatter deprecation warning link to `https://stylelint.io/awesome-stylelint#formatters` ([#8115](stylelint/stylelint#8115)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `function-calc-no-unspaced-operator` false negatives for `calc-size` ([#8026](stylelint/stylelint#8026)) ([@azat-io](https://github.com/azat-io)). - Fixed: `max-nesting-depth` false positives when the `&` selector is being ignored ([#8048](stylelint/stylelint#8048)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `media-feature-name-value-no-unknown` false positives for `display-mode: picture-in-picture` ([#8136](stylelint/stylelint#8136)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `no-irregular-whitespace` reported ranges ([#8066](stylelint/stylelint#8066)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `selector-attribute-name-disallowed-list` reported ranges ([#8037](stylelint/stylelint#8037)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-attribute-operator-allowed-list` reported ranges ([#8038](stylelint/stylelint#8038)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-attribute-operator-disallowed-list` reported ranges ([#8039](stylelint/stylelint#8039)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-class-pattern` reported ranges ([#8042](stylelint/stylelint#8042)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-combinator-allowed-list` reported ranges ([#8046](stylelint/stylelint#8046)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-combinator-disallowed-list` reported ranges ([#8047](stylelint/stylelint#8047)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-disallowed-list` reported ranges ([#8067](stylelint/stylelint#8067)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-id-pattern` reported ranges ([#8045](stylelint/stylelint#8045)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-attribute` reported ranges ([#8052](stylelint/stylelint#8052)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-class` reported ranges ([#8053](stylelint/stylelint#8053)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-combinators` reported-ranges ([#8055](stylelint/stylelint#8055)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-compound-selectors` reported ranges ([#8056](stylelint/stylelint#8056)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-id` reported ranges ([#8054](stylelint/stylelint#8054)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-pseudo-class` reported ranges ([#8057](stylelint/stylelint#8057)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-specificity` reported ranges ([#8058](stylelint/stylelint#8058)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-universal` reported ranges ([#8059](stylelint/stylelint#8059)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-nested-pattern` reported ranges ([#8072](stylelint/stylelint#8072)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-no-vendor-prefix` reported ranges ([#8073](stylelint/stylelint#8073)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-not-notation` reported ranges ([#8074](stylelint/stylelint#8074)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-class-allowed-list` reported ranges ([#8061](stylelint/stylelint#8061)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-class-disallowed-list` reported ranges ([#8062](stylelint/stylelint#8062)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-class-no-unknown` reported ranges ([#8063](stylelint/stylelint#8063)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-element-allowed-list` reported ranges ([#8068](stylelint/stylelint#8068)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-element-colon-notation` reported ranges ([#8069](stylelint/stylelint#8069)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-element-disallowed-list` reported ranges ([#8070](stylelint/stylelint#8070)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-element-no-unknown` false positives for `::scroll-marker` and `::scroll-marker-group` ([#8110](stylelint/stylelint#8110)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-element-no-unknown` reported ranges ([#8071](stylelint/stylelint#8071)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-type-no-unknown` reported ranges ([#8076](stylelint/stylelint#8076)) ([@ryo-manba](https://github.com/ryo-manba)).

Fix no-irregular-whitespace reported ranges

98fd8ab

romainmenke commented Oct 21, 2024

View reviewed changes

Create spicy-squids-admire.md

afb5930

romainmenke mentioned this pull request Oct 21, 2024

Fix reported ranges of warnings in selectors #7904

Closed

38 tasks

romainmenke added 2 commits October 21, 2024 20:50

increase test coverage

ad64f99

Merge branch 'fix-no-irregular-whitespace-reported-ranges--passionate…

ab50e76

…-masked-palm-civet-aa54d96cf9' of https://github.com/stylelint/stylelint into fix-no-irregular-whitespace-reported-ranges--passionate-masked-palm-civet-aa54d96cf9

Mouvedia reviewed Oct 23, 2024

View reviewed changes

lib/utils/atRuleRawsAfterIndex.mjs Outdated Show resolved Hide resolved

fix after indices

d705b4e

romainmenke commented Oct 24, 2024

View reviewed changes

lib/utils/ruleRawsAfterIndex.mjs Outdated Show resolved Hide resolved

Mouvedia reviewed Oct 27, 2024

View reviewed changes

lib/utils/__tests__/atRuleRawsAfterNameIndex.test.mjs Outdated Show resolved Hide resolved

Mouvedia reviewed Oct 27, 2024

View reviewed changes

lib/rules/no-irregular-whitespace/index.mjs Show resolved Hide resolved

romainmenke and others added 2 commits October 29, 2024 19:49

apply suggestions from code review

db4ce62

Merge branch 'main' into fix-no-irregular-whitespace-reported-ranges-…

cdc3681

…-passionate-masked-palm-civet-aa54d96cf9

Mouvedia reviewed Oct 29, 2024

View reviewed changes

lib/utils/atRuleParamIndex.mjs Outdated Show resolved Hide resolved

Revert "apply suggestions from code review"

e01ede1

This reverts commit db4ce62.

romainmenke mentioned this pull request Oct 29, 2024

Refactor to improve utilities to get source location indices #8097

Closed

romainmenke and others added 3 commits October 29, 2024 23:18

fix incorrect ranges when comments are present

eecb1ee

Merge branch 'main' into fix-no-irregular-whitespace-reported-ranges-…

2b337d0

…-passionate-masked-palm-civet-aa54d96cf9

Merge branch 'main' into fix-no-irregular-whitespace-reported-ranges-…

60a2724

…-passionate-masked-palm-civet-aa54d96cf9

Mouvedia mentioned this pull request Nov 11, 2024

Release 16.11.0 #8121

Closed

11 tasks

ybiquitous reviewed Nov 12, 2024

View reviewed changes

romainmenke mentioned this pull request Nov 13, 2024

Refactor to group functions that calculate node field indices #8125

Merged

romainmenke added 3 commits November 16, 2024 17:12

Merge remote-tracking branch 'origin/main' into fix-no-irregular-whit…

d112a72

…espace-reported-ranges--passionate-masked-palm-civet-aa54d96cf9

integrate new helpers

b4112d5

cleanup

b006045

Mouvedia reviewed Nov 16, 2024

View reviewed changes

lib/rules/no-irregular-whitespace/__tests__/index.mjs Outdated Show resolved Hide resolved

lib/rules/no-irregular-whitespace/__tests__/index.mjs Outdated Show resolved Hide resolved

lib/rules/no-irregular-whitespace/index.cjs Show resolved Hide resolved

apply suggestions from code review

fcf29c0

ybiquitous approved these changes Nov 17, 2024

View reviewed changes

romainmenke merged commit 18b0856 into main Nov 17, 2024
17 checks passed

romainmenke deleted the fix-no-irregular-whitespace-reported-ranges--passionate-masked-palm-civet-aa54d96cf9 branch November 17, 2024 08:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `no-irregular-whitespace` reported ranges #8066

Fix `no-irregular-whitespace` reported ranges #8066

romainmenke commented Oct 21, 2024 •

edited

Loading

changeset-bot bot commented Oct 21, 2024 •

edited

Loading

romainmenke Oct 21, 2024

ybiquitous left a comment •

edited

Loading

Mouvedia commented Nov 12, 2024

romainmenke commented Nov 16, 2024

Mouvedia left a comment

ybiquitous left a comment

Fix no-irregular-whitespace reported ranges #8066

Fix no-irregular-whitespace reported ranges #8066

Conversation

romainmenke commented Oct 21, 2024 • edited Loading

changeset-bot bot commented Oct 21, 2024 • edited Loading

🦋 Changeset detected

romainmenke Oct 21, 2024

Choose a reason for hiding this comment

ybiquitous left a comment • edited Loading

Choose a reason for hiding this comment

Mouvedia commented Nov 12, 2024

romainmenke commented Nov 16, 2024

Mouvedia left a comment

Choose a reason for hiding this comment

ybiquitous left a comment

Choose a reason for hiding this comment

Fix `no-irregular-whitespace` reported ranges #8066

Fix `no-irregular-whitespace` reported ranges #8066

romainmenke commented Oct 21, 2024 •

edited

Loading

changeset-bot bot commented Oct 21, 2024 •

edited

Loading

ybiquitous left a comment •

edited

Loading