Add `ignoreFunctions: []` to `media-query-no-invalid` #8060

ryo-manba · 2024-10-20T03:52:06Z

Which issue, if any, is this issue related to?

Closes #7934

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

changeset-bot · 2024-10-20T03:52:09Z

🦋 Changeset detected

Latest commit: c3a89d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
stylelint	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ryo-manba · 2024-10-20T03:56:27Z

lib/rules/media-query-no-invalid/README.md

+
+## Optional secondary options
+
+### `ignoreFunctions: ["/regex/", /regex/, "string"]`


This PR isn't directly related, but it might be good to standardize the ignoreFunctions docs wording. https://github.com/search?q=repo%3Astylelint%2Fstylelint%20%23%23%23%20%60ignoreFunctions%3A%20%5B&type=code

I agree.
I think it should be done at the same time as #3372.

romainmenke

Thank you @ryo-manba,

I've left a suggestion, please let me know what you think

ryo-manba · 2024-10-20T11:17:38Z

@romainmenke
It seems that the review hasn't been reflected yet.
Could you please check it?

romainmenke

Somehow my review comment was lost, thank you for pointing that out

lib/rules/media-query-no-invalid/index.mjs

lib/rules/media-query-no-invalid/__tests__/index.mjs

romainmenke

LGTM!
@ryo-manba thank you for working on this issue and for applying all the feedback!

I am going to leave this open so that @ybiquitous can also take a look.

lib/rules/media-query-no-invalid/index.mjs

resolved

lib/rules/media-query-no-invalid/index.mjs

Co-authored-by: Gary Gozlan <Mouvedia@users.noreply.github.com>

lib/rules/media-query-no-invalid/index.cjs

lib/rules/media-query-no-invalid/README.md

lib/rules/media-query-no-invalid/index.mjs

ybiquitous · 2024-11-07T13:16:58Z

Sorry for the late response. I'm looking at this 👀

lib/rules/media-query-no-invalid/README.md

lib/rules/media-query-no-invalid/index.mjs

ybiquitous

Thanks for addressing the reviews!
I've left a minor question, but it's not a blocker. LGTM 👍🏼

lib/rules/media-query-no-invalid/README.md

ybiquitous · 2024-11-09T05:53:27Z

@Mouvedia Do you have any concerns still? If no, we can merge.

lib/rules/media-query-no-invalid/__tests__/index.mjs

Mouvedia · 2024-11-09T11:14:23Z

Do you have any concerns still? If no, we can merge.

@ybiquitous Just go ahead, I don't like that it doesn't have range syntax tests but that's minor.

romainmenke · 2024-11-09T11:46:08Z

I don't like that it doesn't have range syntax tests but that's minor.

That would not meaningfully increase test coverage.

Anything unrecognized becomes GeneralEnclosed.
It doesn't matter which other tokens you add to it (or remove from it).

(min-width: foo()) is the same as (width < foo()) and also as (foo()) it's all a GeneralEnclosed containing a foo() function.

Mouvedia · 2024-11-09T11:56:36Z

@romainmenke like I said, it's minor, but test cases shouldn't be strongly tied to implementation details.

romainmenke

@ryo-manba LGTM 👍

Thank you everyone for working on this new plugin option 🙇

@Mouvedia

| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.10.0 | 16.11.0 | ## [v16.11.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16110) - Added: `--report-unscoped-disables` CLI flag and `reportUnscopedDisables` option to Node.js API and configuration object ([#8024](stylelint/stylelint#8024)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `ignoreFunctions: []` to `media-query-no-invalid` ([#8060](stylelint/stylelint#8060)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `name` configuration property under `overrides` ([#8095](stylelint/stylelint#8095)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `benchmark-rule` script to resolve `TypeError` ([#8090](stylelint/stylelint#8090)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: `github` formatter deprecation warning link to `https://stylelint.io/awesome-stylelint#formatters` ([#8115](stylelint/stylelint#8115)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `function-calc-no-unspaced-operator` false negatives for `calc-size` ([#8026](stylelint/stylelint#8026)) ([@azat-io](https://github.com/azat-io)). - Fixed: `max-nesting-depth` false positives when the `&` selector is being ignored ([#8048](stylelint/stylelint#8048)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `media-feature-name-value-no-unknown` false positives for `display-mode: picture-in-picture` ([#8136](stylelint/stylelint#8136)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `no-irregular-whitespace` reported ranges ([#8066](stylelint/stylelint#8066)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `selector-attribute-name-disallowed-list` reported ranges ([#8037](stylelint/stylelint#8037)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-attribute-operator-allowed-list` reported ranges ([#8038](stylelint/stylelint#8038)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-attribute-operator-disallowed-list` reported ranges ([#8039](stylelint/stylelint#8039)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-class-pattern` reported ranges ([#8042](stylelint/stylelint#8042)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-combinator-allowed-list` reported ranges ([#8046](stylelint/stylelint#8046)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-combinator-disallowed-list` reported ranges ([#8047](stylelint/stylelint#8047)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-disallowed-list` reported ranges ([#8067](stylelint/stylelint#8067)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-id-pattern` reported ranges ([#8045](stylelint/stylelint#8045)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-attribute` reported ranges ([#8052](stylelint/stylelint#8052)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-class` reported ranges ([#8053](stylelint/stylelint#8053)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-combinators` reported-ranges ([#8055](stylelint/stylelint#8055)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-compound-selectors` reported ranges ([#8056](stylelint/stylelint#8056)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-id` reported ranges ([#8054](stylelint/stylelint#8054)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-pseudo-class` reported ranges ([#8057](stylelint/stylelint#8057)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-specificity` reported ranges ([#8058](stylelint/stylelint#8058)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-universal` reported ranges ([#8059](stylelint/stylelint#8059)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-nested-pattern` reported ranges ([#8072](stylelint/stylelint#8072)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-no-vendor-prefix` reported ranges ([#8073](stylelint/stylelint#8073)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-not-notation` reported ranges ([#8074](stylelint/stylelint#8074)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-class-allowed-list` reported ranges ([#8061](stylelint/stylelint#8061)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-class-disallowed-list` reported ranges ([#8062](stylelint/stylelint#8062)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-class-no-unknown` reported ranges ([#8063](stylelint/stylelint#8063)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-element-allowed-list` reported ranges ([#8068](stylelint/stylelint#8068)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-element-colon-notation` reported ranges ([#8069](stylelint/stylelint#8069)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-element-disallowed-list` reported ranges ([#8070](stylelint/stylelint#8070)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-element-no-unknown` false positives for `::scroll-marker` and `::scroll-marker-group` ([#8110](stylelint/stylelint#8110)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-element-no-unknown` reported ranges ([#8071](stylelint/stylelint#8071)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-type-no-unknown` reported ranges ([#8076](stylelint/stylelint#8076)) ([@ryo-manba](https://github.com/ryo-manba)).

@Mouvedia

| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.10.0 | 16.11.0 | ## [v16.11.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16110) - Added: `--report-unscoped-disables` CLI flag and `reportUnscopedDisables` option to Node.js API and configuration object ([#8024](stylelint/stylelint#8024)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `ignoreFunctions: []` to `media-query-no-invalid` ([#8060](stylelint/stylelint#8060)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `name` configuration property under `overrides` ([#8095](stylelint/stylelint#8095)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `benchmark-rule` script to resolve `TypeError` ([#8090](stylelint/stylelint#8090)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: `github` formatter deprecation warning link to `https://stylelint.io/awesome-stylelint#formatters` ([#8115](stylelint/stylelint#8115)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `function-calc-no-unspaced-operator` false negatives for `calc-size` ([#8026](stylelint/stylelint#8026)) ([@azat-io](https://github.com/azat-io)). - Fixed: `max-nesting-depth` false positives when the `&` selector is being ignored ([#8048](stylelint/stylelint#8048)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `media-feature-name-value-no-unknown` false positives for `display-mode: picture-in-picture` ([#8136](stylelint/stylelint#8136)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `no-irregular-whitespace` reported ranges ([#8066](stylelint/stylelint#8066)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `selector-attribute-name-disallowed-list` reported ranges ([#8037](stylelint/stylelint#8037)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-attribute-operator-allowed-list` reported ranges ([#8038](stylelint/stylelint#8038)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-attribute-operator-disallowed-list` reported ranges ([#8039](stylelint/stylelint#8039)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-class-pattern` reported ranges ([#8042](stylelint/stylelint#8042)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-combinator-allowed-list` reported ranges ([#8046](stylelint/stylelint#8046)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-combinator-disallowed-list` reported ranges ([#8047](stylelint/stylelint#8047)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-disallowed-list` reported ranges ([#8067](stylelint/stylelint#8067)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-id-pattern` reported ranges ([#8045](stylelint/stylelint#8045)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-attribute` reported ranges ([#8052](stylelint/stylelint#8052)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-class` reported ranges ([#8053](stylelint/stylelint#8053)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-combinators` reported-ranges ([#8055](stylelint/stylelint#8055)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-compound-selectors` reported ranges ([#8056](stylelint/stylelint#8056)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-id` reported ranges ([#8054](stylelint/stylelint#8054)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-pseudo-class` reported ranges ([#8057](stylelint/stylelint#8057)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-specificity` reported ranges ([#8058](stylelint/stylelint#8058)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-max-universal` reported ranges ([#8059](stylelint/stylelint#8059)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-nested-pattern` reported ranges ([#8072](stylelint/stylelint#8072)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-no-vendor-prefix` reported ranges ([#8073](stylelint/stylelint#8073)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-not-notation` reported ranges ([#8074](stylelint/stylelint#8074)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-class-allowed-list` reported ranges ([#8061](stylelint/stylelint#8061)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-class-disallowed-list` reported ranges ([#8062](stylelint/stylelint#8062)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-class-no-unknown` reported ranges ([#8063](stylelint/stylelint#8063)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-element-allowed-list` reported ranges ([#8068](stylelint/stylelint#8068)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-element-colon-notation` reported ranges ([#8069](stylelint/stylelint#8069)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-element-disallowed-list` reported ranges ([#8070](stylelint/stylelint#8070)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-pseudo-element-no-unknown` false positives for `::scroll-marker` and `::scroll-marker-group` ([#8110](stylelint/stylelint#8110)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-element-no-unknown` reported ranges ([#8071](stylelint/stylelint#8071)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `selector-type-no-unknown` reported ranges ([#8076](stylelint/stylelint#8076)) ([@ryo-manba](https://github.com/ryo-manba)).

ryo-manba added 2 commits October 20, 2024 12:50

Add ignoreFunctions: [] to media-query-no-invalid

4c593a9

Add ignoreFunctions option to media-query-no-invalid docs

1c96204

ryo-manba commented Oct 20, 2024

View reviewed changes

romainmenke reviewed Oct 20, 2024

View reviewed changes

lib/rules/media-query-no-invalid/index.mjs Outdated Show resolved Hide resolved

lib/rules/media-query-no-invalid/__tests__/index.mjs Show resolved Hide resolved

Mouvedia reviewed Oct 20, 2024

View reviewed changes

lib/rules/media-query-no-invalid/__tests__/index.mjs Outdated Show resolved Hide resolved

ryo-manba added 3 commits October 21, 2024 23:01

fix: ignore entire GeneralEnclosed if an ignored function is detected

3e93839

feat: add support for ignoreFunctions in isMediaQueryInvalid

97f3274

add: commas split test

7d19c38

romainmenke approved these changes Oct 21, 2024

View reviewed changes

Create funny-islands-rest.md

7f32801

This comment was marked as resolved.

Sign in to view

Mouvedia reviewed Oct 24, 2024

View reviewed changes

lib/rules/media-query-no-invalid/index.mjs Outdated Show resolved Hide resolved

Mouvedia reviewed Oct 24, 2024

View reviewed changes

lib/rules/media-query-no-invalid/index.mjs Outdated Show resolved Hide resolved

ryo-manba added 2 commits October 25, 2024 21:54

chore: fix type definition

8b6ad48

chore: add strict type definition for SecondaryOptions

ae03274

ryo-manba requested a review from Mouvedia October 25, 2024 12:57

Mouvedia reviewed Oct 25, 2024

View reviewed changes

lib/rules/media-query-no-invalid/index.mjs Outdated Show resolved Hide resolved

refactor: simplify types using typedef

d3d4f47

Mouvedia reviewed Oct 25, 2024

View reviewed changes

lib/rules/media-query-no-invalid/index.mjs Outdated Show resolved Hide resolved

Update lib/rules/media-query-no-invalid/index.mjs

a8cbcce

Co-authored-by: Gary Gozlan <Mouvedia@users.noreply.github.com>

Mouvedia reviewed Oct 25, 2024

View reviewed changes

lib/rules/media-query-no-invalid/index.cjs Outdated Show resolved Hide resolved

Update lib/rules/media-query-no-invalid/index.cjs

72a820c

Mouvedia reviewed Nov 7, 2024

View reviewed changes

lib/rules/media-query-no-invalid/README.md Outdated Show resolved Hide resolved

lib/rules/media-query-no-invalid/index.mjs Outdated Show resolved Hide resolved

ybiquitous reviewed Nov 7, 2024

View reviewed changes

lib/rules/media-query-no-invalid/README.md Outdated Show resolved Hide resolved

ybiquitous reviewed Nov 7, 2024

View reviewed changes

lib/rules/media-query-no-invalid/index.mjs Outdated Show resolved Hide resolved

ybiquitous reviewed Nov 7, 2024

View reviewed changes

lib/rules/media-query-no-invalid/index.mjs Show resolved Hide resolved

ybiquitous reviewed Nov 7, 2024

View reviewed changes

lib/rules/media-query-no-invalid/index.mjs Outdated Show resolved Hide resolved

ybiquitous reviewed Nov 7, 2024

View reviewed changes

lib/rules/media-query-no-invalid/index.mjs Outdated Show resolved Hide resolved

ryo-manba added 3 commits November 7, 2024 23:54

Update README.md

fdf7de1

Merge branch 'main' into add-ignore-functions-to-media-query-no-invalid

e174676

apply code review suggestion

de4e392

ryo-manba requested review from ybiquitous and Mouvedia November 7, 2024 15:45

ybiquitous approved these changes Nov 8, 2024

View reviewed changes

lib/rules/media-query-no-invalid/README.md Show resolved Hide resolved

remove redundant examples

c3a89d7

ybiquitous approved these changes Nov 9, 2024

View reviewed changes

Mouvedia reviewed Nov 9, 2024

View reviewed changes

lib/rules/media-query-no-invalid/__tests__/index.mjs Show resolved Hide resolved

romainmenke approved these changes Nov 10, 2024

View reviewed changes

romainmenke merged commit bf3fe6d into stylelint:main Nov 10, 2024
17 checks passed

ryo-manba deleted the add-ignore-functions-to-media-query-no-invalid branch November 11, 2024 00:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `ignoreFunctions: []` to `media-query-no-invalid` #8060

Add `ignoreFunctions: []` to `media-query-no-invalid` #8060

ryo-manba commented Oct 20, 2024

changeset-bot bot commented Oct 20, 2024 •

edited

Loading

ryo-manba Oct 20, 2024

Mouvedia Oct 20, 2024

romainmenke left a comment

ryo-manba commented Oct 20, 2024

romainmenke left a comment

romainmenke left a comment

This comment was marked as resolved.

ybiquitous commented Nov 7, 2024

ybiquitous left a comment

ybiquitous commented Nov 9, 2024

Mouvedia commented Nov 9, 2024 •

edited

Loading

romainmenke commented Nov 9, 2024

Mouvedia commented Nov 9, 2024

romainmenke left a comment


		## Optional secondary options

		### `ignoreFunctions: ["/regex/", /regex/, "string"]`

Add ignoreFunctions: [] to media-query-no-invalid #8060

Add ignoreFunctions: [] to media-query-no-invalid #8060

Conversation

ryo-manba commented Oct 20, 2024

changeset-bot bot commented Oct 20, 2024 • edited Loading

🦋 Changeset detected

ryo-manba Oct 20, 2024

Choose a reason for hiding this comment

Mouvedia Oct 20, 2024

Choose a reason for hiding this comment

romainmenke left a comment

Choose a reason for hiding this comment

ryo-manba commented Oct 20, 2024

romainmenke left a comment

Choose a reason for hiding this comment

romainmenke left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

ybiquitous commented Nov 7, 2024

ybiquitous left a comment

Choose a reason for hiding this comment

ybiquitous commented Nov 9, 2024

Mouvedia commented Nov 9, 2024 • edited Loading

romainmenke commented Nov 9, 2024

Mouvedia commented Nov 9, 2024

romainmenke left a comment

Choose a reason for hiding this comment

Add `ignoreFunctions: []` to `media-query-no-invalid` #8060

Add `ignoreFunctions: []` to `media-query-no-invalid` #8060

changeset-bot bot commented Oct 20, 2024 •

edited

Loading

Mouvedia commented Nov 9, 2024 •

edited

Loading