-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix keyframe-selector-notation
keywords for <timeline-range-name>
#7859
Fix keyframe-selector-notation
keywords for <timeline-range-name>
#7859
Conversation
Co-authored-by: Gary Gozlan <Mouvedia@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 6b68fdd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…yframe-selector-notation--courageous-sea-slug-035a79cbda
.changeset/angry-spies-allow.md
Outdated
Fixed: `keyframe-selector-notation` false positives for `entry-crossing` and `exit-crossing` | ||
Fixed: `keyframe-selector-notation` false negatives for `enter` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do two entries?
I vaguely remember that changeset has an issue with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested parse.default
using https://npm.runkit.com/%40changesets%2Fparse; it worked as intended.
i.e. produces {releases: [{name: "stylelint", type: "patch"}], summary: "Fixed: foo\nFixed: bar"}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@romainmenke check #7867 (comment)
|
Ah, yes there was a note:
|
…ea-slug-035a79cbda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to reuse the references. 👍🏼
Once updating the changelog, feel free to merge it.
Thank you for the reviews everyone 🙇 |
See: #7856 (comment)
I looked around but I couldn't find any trace of
enter
as a named timeline range keyword.It might have existed in an earlier version of the spec.
This change moves the list of keywords to
reference/keywords.mjs
and updateskeyframe-selector-notation
to match the latest list.This PR will be merged after #7856 (comment)