Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyframe-selector-notation keywords for <timeline-range-name> #7859

Merged

Conversation

romainmenke
Copy link
Member

Which issue, if any, is this issue related to?

See: #7856 (comment)

Is there anything in the PR that needs further explanation?

I looked around but I couldn't find any trace of enter as a named timeline range keyword.
It might have existed in an earlier version of the spec.

This change moves the list of keywords to reference/keywords.mjs and updates keyframe-selector-notation to match the latest list.


This PR will be merged after #7856 (comment)

Copy link

changeset-bot bot commented Jul 18, 2024

🦋 Changeset detected

Latest commit: 6b68fdd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines 5 to 6
Fixed: `keyframe-selector-notation` false positives for `entry-crossing` and `exit-crossing`
Fixed: `keyframe-selector-notation` false negatives for `enter`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do two entries?
I vaguely remember that changeset has an issue with this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested parse.default using https://npm.runkit.com/%40changesets%2Fparse; it worked as intended.
i.e. produces {releases: [{name: "stylelint", type: "patch"}], summary: "Fixed: foo\nFixed: bar"}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mouvedia
Copy link
Member

I looked around but I couldn't find any trace of enter as a named timeline range keyword.
It might have existed in an earlier version of the spec.

#6605 (comment)

@romainmenke
Copy link
Member Author

Ah, yes there was a note:

Should this be entry or enter?

Base automatically changed from is-keyframe-selector--witty-ant-add7bd46d2 to main July 21, 2024 07:36
@romainmenke romainmenke marked this pull request as ready for review July 21, 2024 07:36
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to reuse the references. 👍🏼

Once updating the changelog, feel free to merge it.

@romainmenke
Copy link
Member Author

Thank you for the reviews everyone 🙇

@romainmenke romainmenke merged commit fe1aa80 into main Jul 22, 2024
17 checks passed
@romainmenke romainmenke deleted the fix-keyframe-selector-notation--courageous-sea-slug-035a79cbda branch July 22, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants