Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1356389: Use junit assertions instead of jvm assert in tests #1743

Merged
merged 1 commit into from
Apr 30, 2024
Merged

SNOW-1356389: Use junit assertions instead of jvm assert in tests #1743

merged 1 commit into from
Apr 30, 2024

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Overview

SNOW-1356389

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner April 30, 2024 10:04
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-1356389-use-junit-assertions-instead-of-jvm-assert-in-tests branch from 9c60cd4 to a49244e Compare April 30, 2024 10:32
sfc-gh-pmotacki
sfc-gh-pmotacki approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 9e1c486 into master Apr 30, 2024
37 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-1356389-use-junit-assertions-instead-of-jvm-assert-in-tests branch April 30, 2024 12:42
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-dprzybysz @sfc-gh-pbulawa @sfc-gh-pmotacki