Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Revert] [SNOW-799391] Add troubleshoot msg for ssl errors #1407

Merged
merged 2 commits into from
Jun 1, 2023
Merged

[Revert] [SNOW-799391] Add troubleshoot msg for ssl errors #1407

merged 2 commits into from
Jun 1, 2023

Conversation

sfc-gh-skumbham
Copy link
Contributor

Overview

Revert PR: https://github.com/snowflakedb/snowflake-jdbc/pull/1369/files
SNOW-799391 . The reason for revert is mentioned in JIRA

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-skumbham sfc-gh-skumbham requested a review from a team as a code owner May 30, 2023 22:07
sfc-gh-igarish
sfc-gh-igarish approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need to remove from release notes? Please check.

@sonarqubemergegate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-skumbham sfc-gh-skumbham merged commit 7a69141 into master Jun 1, 2023
@sfc-gh-skumbham sfc-gh-skumbham deleted the skumbham-SNOW-759147-revert branch June 1, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-skumbham @sfc-gh-igarish