[SNOW-804206] 3. Instantiate JDK14Logger with sf client configuration #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-skumbham
changed the title
sfc-gh-skumbham
force-pushed
the
skumbham-config-file-locator-3
branch
2 times, most recently
from
2a804c1 to
ae35134
Compare
sfc-gh-skumbham
force-pushed
the
skumbham-config-file-locator-3
branch
from
ae35134 to
d5005d9
Compare
|
SonarQube Quality Gate
|
| (String) connectionPropertiesMap.getOrDefault(SFSessionProperty.TRACING, null); | ||
|
|
||
| Level logLevel = null; | ||
| String logPattern = "%t/snowflake_jdbc%u.log"; // default pattern. |
There was a problem hiding this comment.
if %t for time and %u for user then can we switch it? like %u/snowflake_jdbc_%t.log?
There was a problem hiding this comment.
@sfc-gh-igarish We could. But we currently use %t/snowflake_jdbc%u.log this format so I kept it as-is for backward compatibility.
ref: https://github.com/snowflakedb/snowflake-jdbc/blob/master/src/main/java/net/snowflake/client/log/JDK14Logger.java#L288
sfc-gh-igarish
approved these changes
May 11, 2023
Yeah, verified. It creates one log file/process: 
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-804206
The SF CONFIG file introduces various logging possibilities when used in conjunction with the
tracingconnection property andlogging.propertiesfor JDK14Logger. Please note that the SF CONFIG file is only applicable toJDK14LoggerasSL4JLoggercannot be instantiated.If
-Djava.util.logging.config.filesystem property is not defined, the following actions will be taken:- Check log level from config file
- Default value is Level.OFF
- If there are permission errors, throws a SQLException
- If no output path value is found in LogPath, defaults to java.io.tmpDir
External contributors - please answer these questions before submitting a pull request. Thanks!
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
Pre-review checklist