Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-748294 Fix test failures #1287

Merged
merged 2 commits into from
Mar 10, 2023
Merged

SNOW-748294 Fix test failures #1287

merged 2 commits into from
Mar 10, 2023

Conversation

sfc-gh-mknister
Copy link
Contributor

@sfc-gh-mknister sfc-gh-mknister commented Mar 9, 2023 •
edited
Loading

Overview

SNOW-748294

Fix failing StreamIT test by moving to LatestIT
Add GCS_DOWNSCOPING_CREDENTIAL=true for GCS stream download tests. Presigned URL is not set up for these tests. This param is false by default and must be set explicitly for jenkins testing (Note that Simba has this param set to true by default)

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-mknister sfc-gh-mknister requested a review from a team as a code owner March 9, 2023 17:46
@sfc-gh-mknister sfc-gh-mknister changed the title SNOW-748294 Move test from regular to latest IT to stop test failure SNOW-748294 Fix test failures Mar 9, 2023
sfc-gh-igarish
sfc-gh-igarish approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubemergegate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-mknister sfc-gh-mknister force-pushed the fixFailingOldDriverTest branch from 3141ba2 to b042f84 Compare March 9, 2023 22:12
@sfc-gh-mknister sfc-gh-mknister force-pushed the fixFailingOldDriverTest branch from b042f84 to 10b039c Compare March 9, 2023 22:13
@sfc-gh-mknister sfc-gh-mknister enabled auto-merge (squash) March 10, 2023 00:17
@sfc-gh-mknister sfc-gh-mknister merged commit 85381e7 into master Mar 10, 2023
@sfc-gh-mknister sfc-gh-mknister deleted the fixFailingOldDriverTest branch March 10, 2023 01:40
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-mknister @sfc-gh-igarish