Use __future__.annotations module #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jku
changed the title
This allows us to use even python 3.10 annotation features already. * start using "X | None" instead of Optional[X] * Drop the quotes from factory function return values This also keeps us compatible with python 3.8 for now. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
jku
force-pushed
the
use-future-annotations
branch
from
fffb1c0 to
c6fe086
Compare
|
Not quite sure who is available for review: flagged @adityasaky but no problem if you're not available |
This comment was marked as outdated.
This comment was marked as outdated.
We are still compatible with 3.8: let's not be the first ones to drop compatibility. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
adityasaky
approved these changes
Nov 29, 2024
No, and I would even say it's not supported: I just don't want to be the first one to explicitly break potential 3.8 users if it's easy to avoid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra import is a little annoying but allows using even python 3.10 annotation features already, which I like.
This also keeps us compatible with python 3.8 for the moment.