Propagate errors on Tree::walk #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edrevo
force-pushed
the
edrevo/fix-tree-walk
branch
from
f0ea72d to
1cd7a94
Compare
edrevo
force-pushed
the
edrevo/fix-tree-walk
branch
from
1cd7a94 to
41d8e06
Compare
|
@weihanglo, would you be able to take a look at this PR? |
* I'm pretty sure the fn pointer doesn't need to have `*const`. * No need to move `Convert` around, can just use `as` for an enum (can maybe just remove this impl?). * Verify the actual error in the test.
ehuss
force-pushed
the
edrevo/fix-tree-walk
branch
from
3ce2f87 to
e0d7dae
Compare
ehuss
approved these changes
Jan 4, 2025
There was a problem hiding this comment.
Thanks! I pushed an update to try to minimize some of the changes here.
I'm not really clear on why d70b645 made all function pointers Option. In this particular case, the pointer cannot be NULL, so it seems like it should be fine. 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tree::walkwas ignoring errors coming fromlibgit2. This PR fixes that and adds a unit test.