Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📈 Update parser benchmark comparison #224

Merged
merged 1 commit into from
Nov 12, 2023
Merged

📈 Update parser benchmark comparison #224

merged 1 commit into from
Nov 12, 2023

Conversation

nevans
Copy link
Collaborator

@nevans nevans commented Nov 12, 2023

  • strip out ruby/object, to load yml without loading Net::IMAP objects.
  • delete and ignore generated benchmark file
  • copy the response strings directly into benchmark, so older versions don't need to load the test yaml at all (they may not be able to).

@nevans
📈 Update parser benchmark comparison
99c0c72 
* strip out ruby/object, to load yml without loading Net::IMAP objects.
* delete and ignore generated benchmark file
* copy the response strings directly into benchmark, so older versions
  don't need to load the test yaml at all (they may not be able to).
@nevans nevans merged commit 8a60524 into ruby:master Nov 12, 2023
11 checks passed
@nevans nevans deleted the parser/update-benchmark-generation branch November 12, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nevans