Support passing the target ruby version through an environment variable #13607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
force-pushed
the
trevor/ruby-version-env-var
branch
from
143314e to
ee4ec2c
Compare
|
Can you document how to use the environment variable |
Add a new search method for determining the target ruby version: the RUBOCOP_TARGET_RUBY_VERSION environment variable. This is now the first source checked, allowing it to override all other sources of the target ruby version.
elliottt
force-pushed
the
trevor/ruby-version-env-var
branch
from
ee4ec2c to
ab42154
Compare
|
@koic I've updated the docs, sorry for missing them initially! |
koic
approved these changes
Dec 20, 2024
|
Agreed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 1.67, the search order for the target ruby version changed to prefer gemspec files over
.ruby-version. While this is a good change as the gemspec is a better authority on what version of ruby a gem requires, it complicates some internal testing at Stripe where we forbid tests from globbing the filesystem, and finding the gemspec requires globbing in parent directories.As a workaround, this PR adds a new source for the target ruby version: the
RUBOCOP_TARGET_RUBY_VERSIONenvironment variable. This is now the first tried source for the target ruby version, giving an environmental override for situations where searching the filesystem isn't permitted.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.