Fix infinite loop error for Style/IfWithSemicolon
#13497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Nov 26, 2024
| @@ -14,6 +14,7 @@ module Style | |||
| # result = some_condition ? something : another_thing | |||
| # | |||
| class IfWithSemicolon < Base | |||
| include IgnoredNode | |||
There was a problem hiding this comment.
IgnoredNode is already included in RuboCop::Cop::Base, so including it again inside a cop is redundant.
There was a problem hiding this comment.
Ah, I see! I've updated this PR. Thank you.
This PR fixes infinite loop error for `Style/IfWithSemicolon` when using nested if/;/end in if body. ```console $ cat example.rb if cond1; foo + if cond2; bar else end end $ bundle exec rubocop -a -d (snip) Parser::Source::TreeRewriter detected clobbering /Users/koic/.rbenv/versions/3.4-dev/lib/ruby/gems/3.4.0+0/gems/parser-3.3.6.0/lib/parser/source/tree_rewriter.rb:427: in 'Parser::Source::TreeRewriter#trigger_policy' /Users/koic/.rbenv/versions/3.4-dev/lib/ruby/gems/3.4.0+0/gems/parser-3.3.6.0/lib/parser/source/tree_rewriter.rb:414: in 'Parser::Source::TreeRewriter#enforce_policy' /Users/koic/.rbenv/versions/3.4-dev/lib/ruby/gems/3.4.0+0/gems/parser-3.3.6.0/lib/parser/source/tree_rewriter/action.rb:234: in 'Method#call' ``` The autocorrection for the nested conventional case is handled as a repeated autocorrection, so there is no impact on the user experience.
koic
force-pushed
the
fix_infinite_loop_error_for_style_if_with_semicolon
branch
from
71169e9 to
326982c
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes infinite loop error for
Style/IfWithSemicolonwhen using nested if/;/end in if body.The autocorrection for the nested conventional case is handled as a repeated autocorrection, so there is no impact on the user experience.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.