Do not force quit Rollup or close stdout #5004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced May 20, 2023
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#no-force-quitor load it into the REPL: |
This was referenced May 20, 2023
Codecov Report
@@ Coverage Diff @@
## master #5004 +/- ##
=======================================
Coverage 98.96% 98.97%
=======================================
Files 222 222
Lines 8155 8157 +2
Branches 2241 2243 +2
=======================================
+ Hits 8071 8073 +2
Misses 30 30
Partials 54 54
|
lukastaegert
force-pushed
the
no-force-quit
branch
from
66c0976 to
67a287b
Compare
lukastaegert
force-pushed
the
no-force-quit
branch
from
67a287b to
ed1e93f
Compare
lukastaegert
force-pushed
the
no-force-quit
branch
from
202a64d to
b916a08
Compare
|
This PR has been released as part of rollup@3.22.1. You can test it via |
|
I will, thank you rollup-bot |
|
3.23.0 does not resolve vercel/turborepo#4983 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverts #4969, #4983
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
prepublishOnlylifecycle #4998Description
This basically reverts #4969 and #4983 as calling
process.exit()orprocess.stdout.end()seems to break various workflows. Instead, we should find out what keeps Rollup from quitting in the first place, maybe some plugins?