-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update magic-string and adjust types. #4846
Conversation
✅ Deploy Preview for rollupjs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I'll update this PR as soon as @Rich-Harris cuts a new release of |
Codecov Report
@@ Coverage Diff @@
## master #4846 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 219 219
Lines 7887 7887
Branches 2184 2184
=======================================
Hits 7808 7808
Misses 26 26
Partials 53 53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I wonder why Node 14 does not want to install magic-string from Github |
I pinged @Rich-Harris to cut a release, so we can wait until that happens. |
The type of `sourcesContent` changed to allow for `null` elements, and rollup needs to be adjusted to that as well.
29d91a1
to
28a68ec
Compare
Updated to the latest release version of magic-string, which brings the typing fixes as well as the This is ready to land now. |
This PR has been released as part of rollup@3.15.1-1. Note that this is a pre-release, so to test it, you need to install Rollup via |
This PR has been released as part of rollup@3.16.0. You can test it via |
The type of
sourcesContent
changed to allow fornull
elements, and rollup needs to be adjusted to that as well.This PR contains:
Description
This PR updates
magic-string
past 0.27, addressing the breaking change in thesourcesContent
type (going fromstring[]
to(string|null)[]
).