fix(typescript): emit declaration files for type-only source files that are not explicitly included #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianyong
commented
Aug 5, 2023
Comment on lines
-26
to
+28
| function isMapOutputFile(name: string): boolean { | ||
| return name.endsWith('.map'); | ||
| export function isMapOutputFile(name: string): boolean { | ||
| return name.endsWith('ts.map'); | ||
| } |
There was a problem hiding this comment.
The reason for this change is that we only need to worry about emitting .d.ts.map (and equivalent .d.cts.map & .d.mts.map) files. The .js.map files are already being emitted by the TypeScript compiler (unless the noEmit option is set to true).
shellscape
requested review from
guybedford,
NotWoods,
lukastaegert and
tada5hi
shellscape
approved these changes
Aug 17, 2023
No, the only change in behaviour is that in the |
tada5hi
approved these changes
Aug 18, 2023
|
|
|
don't report bugs on closed pull requests. open a new issue and follow the issue template |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
@rollup/plugin-typescriptThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
Please read the linked issue first for context.
The core issue is that TypeScript source files which contain only type definitions transpile into nothing. This means that Rollup has no equivalent JavaScript files to operate on (i.e., we cannot handle these files if they are not already included in
tsconfig.jsonbecause within the Rollup build hooks and output generation hooks, these files do not exist). Specifically in the test case added, theexportstatement inmain.tsis removed when transpiling into JavaScript becauseMyNumberis a type. This means that by the time Rollup operates onmain.js, there is no longer any logical link betweenmain.ts&should-be-emitted-types.ts.However, the observation here is that we don't have to manually keep track of which files to emit because the TypeScript compiler already does it for us. Specifically, the TypeScript compiler only emits the files which are necessary (this is verified in the test case I added). This means that we can simply emit all declaration & source map files in
emittedFilesto solve the linked issue.