docs: jokes app tutorial in fetching jokes part #3547
Conversation
at point where reader is only done with building types for `Joke`, the example shows to import `type User` from `@prisma/client`
|
Hi @justinsalasdev, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
use generated type in `type LoaderData`
justinsalasdev
changed the title
pick from `type Joke` on projected query
justinsalasdev
changed the title
There was a problem hiding this comment.
Thank you for your contribution @justinsalasdev !
Left you a couple of remarks to address.
* separated `json` import from `types` import
* imported `Joke` type on `findMany` example - placed directly below `import type`'s for grouping (updated line highlight for new lines added)
* removed `Pick` from projected example and replaced with `{ id:string, name:string }` - add line highlight so reader is aware that original `Joke` type needs to be edited
remove left-over market
There was a problem hiding this comment.
Hi @justinsalasdev. Thanks for the PR.
As noted in the text right before your changes:
this is just an example. No need to copy/paste this 😄
It's only there to give you an idea of how things work as an example so you can finish the goal without looking at the finished version. We purposefully don't use Joke there. I think using Joke would be more confusing because it would lead people to believe that they need to make those changes to their code which they do not.
I'd be more in favor of changing the example completely to be something like Sandwich or something.
update example type from `Joke` to `Sandwich`
@kentcdodds, still can't believe I got an actual pr review from you ^__^ Overall, here are the changes I've done
|
at point where reader is only done with building types for
Joke, the example shows to importtype Userfrom@prisma/clientwhere it is not there yet.the succeeding code continuation also didn't use the built type from
@prisma/client