fix(remix-react): Handle revalidations across multi-redirects #3460
Conversation
| } | ||
|
|
||
| export async function loader({ request }) { | ||
| return { count: ++global.actionCount }; |
There was a problem hiding this comment.
We use a count to confirm how many times this parent loader runs on the redirects
| return ( | ||
| <Form method="post"> | ||
| <button type="submit">Submit</button> | ||
| </Form> |
There was a problem hiding this comment.
Submit the form, which redirects to /action/1 and then to /action/2
| "app/routes/loader/link.jsx": js` | ||
| import { Link } from "@remix-run/react"; | ||
| export default function Parent() { | ||
| return <Link to="/loader/redirect">Redirect</Link>; |
There was a problem hiding this comment.
Click this link, which redirects to /loader/1 then to /loader/2
| state.transition.type === "actionReload" || | ||
| ((location.state as any)?.isRedirect && | ||
| (location.state as any)?.type === "action") | ||
| ) { |
There was a problem hiding this comment.
Stay on the actionRedirect path if the current load is an action redirect
| state.transition.type === "actionReload", | ||
| state.transition.type === "actionReload" || | ||
| // loader redirected during action redirect | ||
| state.transition.type === "actionRedirect", |
There was a problem hiding this comment.
Allow actionRedirect to kick off actionRedirect as well
| // If we're in the middle of a setCookie redirect, we need to preserve | ||
| // the flag so we handle revalidations across multi-redirect scenarios | ||
| setCookie: | ||
| redirect.setCookie || (location.state as any)?.setCookie === true, |
There was a problem hiding this comment.
Preserve the setCookie flag on back to back normalRedirects
MichaelDeBoey
changed the title
|
🤖 Hello there, We just published version Thanks! |
There is some stateful information driving whether or not we revalidate inside transition manager which was getting lost across a redirect boundaries in certain scenarios. This PR fixes two potential flows:
actionRedirect -> normalRedirectand the second loader execution skips reused parent routesactionRedirectlocation.state.setCookieflag on the second redirectsetCookieflag from the current navigation when kicking off a newnormalRedirectCloses: #3302
Testing Strategy: