Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of empty cookies in MockResponse #2203

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Fix handling of empty cookies in MockResponse #2203

merged 5 commits into from
Jun 12, 2024

Conversation

wynksaiddestroy
Copy link
Contributor

Hopefully fixes #2201

ioquatix
ioquatix reviewed Jun 11, 2024
View reviewed changes
lib/rack/mock_response.rb Outdated Show resolved Hide resolved
wynksaiddestroy and others added 2 commits June 12, 2024 02:02
@wynksaiddestroy @ioquatix
Fix handling of empty cookies in MockResponse
62fe653
@wynksaiddestroy @ioquatix
Avoid looking up header hash multiple times
3cb9230 
Co-authored-by: Samuel Williams <samuel.williams@oriontransfer.co.nz>
@ioquatix ioquatix force-pushed the fix-empty-cookie-handling branch from bd38754 to 3cb9230 Compare June 11, 2024 17:02
@ioquatix
Copy link
Member

Can you please add an entry under Fixed in the changelog.

jeremyevans
jeremyevans approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I added a line to CHANGELOG while resolving the conflict in the web editor, but we can remove that later.

@ioquatix
Copy link
Member

I’ll fix it it, merge and backport.

ioquatix
ioquatix reviewed Jun 12, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ioquatix ioquatix merged commit 7d0fe1f into rack:main Jun 12, 2024
15 checks passed
ioquatix pushed a commit that referenced this pull request Jun 12, 2024
@wynksaiddestroy @ioquatix
Fix handling of empty cookies in Rack::MockResponse (#2203)
5c34b37
@ioquatix ioquatix added this to the v3.1.3 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioquatix ioquatix ioquatix left review comments

@jeremyevans jeremyevans jeremyevans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.3
Development

Successfully merging this pull request may close these issues.

MockRequest can't handle an empty cookie anymore
3 participants
@wynksaiddestroy @ioquatix @jeremyevans