Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix arming of keep-alive timer after sending PMTUD probe packets #4716

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

marten-seemann
Copy link
Member

No description provided.

@marten-seemann marten-seemann linked an issue Nov 2, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.95%. Comparing base (98de6ae) to head (f0cd22d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4716   +/-   ##
=======================================
  Coverage   83.95%   83.95%           
=======================================
  Files         151      151           
  Lines       16233    16233           
=======================================
  Hits        13627    13627           
  Misses       2073     2073           
  Partials      533      533           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann
Copy link
Member Author

@glycerine confirmed that this fix resolves the issue in #4710 (comment).

@marten-seemann marten-seemann changed the title fix arming of keep-alive timer after send PMTUD probe packets fix arming of keep-alive timer after sending PMTUD probe packets Nov 4, 2024
@marten-seemann marten-seemann merged commit 955506a into master Nov 4, 2024
35 checks passed
@marten-seemann marten-seemann deleted the fix-keep-alive branch November 15, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requested keep-alives are not attempted sometimes
1 participant