[fix] TLS verification hang on JRuby #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kares Thanks again. Would you like me to cancel the older CI runs? |
nateberkopec
pushed a commit
that referenced
this pull request
Aug 22, 2022
* [fix] jruby hang with TLS due not executing task basically the use of Java SSL API was incorrect and reproduced when verification is enabled - the engine needs to execute a task but the handling code was not reached * Revert "[fix] jruby hang with TLS due not executing task" This reverts commit d1731a5. * [chore] re-generate certs with a subjectAltName ext * [test] more ssl test with server verify peer * [test] a proper reproducer for the TLS hang in JRuby * [test] cleanup and better naming * Revert "[chore] re-generate certs with a subjectAltName ext" This reverts commit a1b01a1. * Revert "Revert "[fix] jruby hang with TLS due not executing task"" This reverts commit 3c5727f. * [test] restore ssl run - hangs with peer on MRI
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
* [fix] jruby hang with TLS due not executing task basically the use of Java SSL API was incorrect and reproduced when verification is enabled - the engine needs to execute a task but the handling code was not reached * Revert "[fix] jruby hang with TLS due not executing task" This reverts commit d1731a5. * [chore] re-generate certs with a subjectAltName ext * [test] more ssl test with server verify peer * [test] a proper reproducer for the TLS hang in JRuby * [test] cleanup and better naming * Revert "[chore] re-generate certs with a subjectAltName ext" This reverts commit a1b01a1. * Revert "Revert "[fix] jruby hang with TLS due not executing task"" This reverts commit 3c5727f. * [test] restore ssl run - hangs with peer on MRI
dentarg
reviewed
Feb 12, 2023
| @@ -93,6 +93,48 @@ def test_ssl_run | |||
| end | |||
| end | |||
|
|
|||
| def test_ssl_run_with_curl_client | |||
| skip_if :windows; require 'stringio' | |||
There was a problem hiding this comment.
@kares was the stringio require here intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The native JRuby extension was not utilizing the Java SSL API properly.
With certain buffering scenarios the internal delegated task was not executed.
This lead to issues such as #2729 (which contains a reproducer).
Closes #2729
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.