Prevent use on Python 3.12.5 #4447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes psf#4446 See python/cpython#123821 It's possible this is too strict? We could instead do this anytime the AST safety check fails, but feels weird to have that happen non-deterministically
|
I think this is probably worth it, otherwise we may get a trickle of hard-to-debug bug reports for the next few years. We could also consider setting Requires-Python to something like Also, great work figuring this out! |
|
Setting Requires-Python won't do what you want. pip will just download an older version of black without the Requires-Python constraint |
Yeah I was worried about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4446
See python/cpython#123821
It's possible this is too strict? We could instead do this anytime the AST safety check fails, but feels weird to have that happen non-deterministically