Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Python and grammar versions to a parser error message #4378

Merged
merged 8 commits into from
Sep 8, 2024

Conversation

smb55
Copy link
Contributor

@smb55 smb55 commented Jun 7, 2024

Description

Improved the parsing error message to make the user aware of the Python version/s and associated grammar version/s that generated the error. This fixes #3294

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@smb55 smb55 changed the title Added Python and grammar versions to a parser error message #3294 Added Python and grammar versions to a parser error message Jun 7, 2024
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I simplified the error message to explicitly mention target version, since it points users directly to the setting affecting them (users don't need to know details about grammar sets)

@hauntsaninja hauntsaninja merged commit 98a580b into psf:main Sep 8, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clearer errorr message for "Cannot parse" when targetting multiple version
3 participants