Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slide map progress bar marks are blurry #7

Closed
owi92 opened this issue Jul 11, 2024 · 2 comments
Closed

Slide map progress bar marks are blurry #7

owi92 opened this issue Jul 11, 2024 · 2 comments

Comments

@owi92
Copy link

owi92 commented Jul 11, 2024

As the title says, and visible in the screenshot below: some of the marks indicating slide changes inside the progress bar are a little blurry, I am not sure if that is intentional though. If not, it would be great if that could be fixed 🙏
Bildschirmfoto 2024-07-11 um 11 48 26

@LukasKalbertodt
Copy link

It seems like a <canvas> is used for drawing these. That canvas is likely just created with a wrong resolution (i.e. too low). You also have to consider the UI scaling factor when creating the canvas.

I would probably suggest to get rid of the canvas altogether and simply use <div>s for these bars. I don't see why a canvas is required/better here.

@ferserc1
Copy link
Collaborator

Slide marks are implemented with a playback bar plugin. This type of plugin was originally created to draw anything on the playback bar, such as a hot map. This is the reason to use a canvas instead of DOM elements.

In version 2.x of paella, which I have been working on for a little over a year now, I have removed this type of plugins because no one has developed any apart from the slide marks, so I see no need to keep them. In version 2, this feature is integrated in the core and the tags are placed using DOM elements.

To solve this problem without having to upgrade to version 2 (which, by the way, I don't know when it will be released), I have modified the API of this type of plugins to support a scaling factor. The new API is in version 1.50.0 of paella-core, and this very morning I am going to update the slide mark plugin to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants