Add support for placing string literals into PHPStan types #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters and return values.
|
Thank you. Could you revert those 2 |
|
I was planning on leaving those out due to #30 |
IanDelMar
reviewed
Oct 17, 2023
|
This is too complex for me. I let you cook this soup! |
Co-authored-by: IanDelMar <42134098+IanDelMar@users.noreply.github.com>
IanDelMar
reviewed
Oct 17, 2023
Co-authored-by: IanDelMar <42134098+IanDelMar@users.noreply.github.com>
|
A big 🟢 green light! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a few parameters in WordPress accept a string from a known list of possible values. This change adds REGULAR EXPRESSIONS to pluck out those possible values from the parameter and return tag docblocks and place them into PHPStan tags. This means anybody using PHPStan will see an error if they attempt to pass an invalid string value.
Take a look at the changes in wordpress-stubs.php to see what I mean.
I've also removed
add_meta_box()andremove_meta_box()from the function map file because they're now redundant.This only handles top-level string parameters and return types for now. Support for string values within args arrays can happen another day.