Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle empty resolver diagnostics array #9407

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Correctly handle empty resolver diagnostics array #9407

merged 4 commits into from
Mar 18, 2024

Conversation

mischnic
Copy link
Member

Previously you could get a strange error message: #9082 (comment)

result.diagnostics was [] and then new ThrowableDiagnostic({diagnostic: result.diagnostics}) evaluated result.diagnostics[0].message so undefined.message

@mischnic mischnic force-pushed the resolver-diagnostics-empty-array branch from 52f131f to 96f3fe0 Compare December 5, 2023 21:26
@mischnic mischnic requested a review from lettertwo December 5, 2023 21:28
@mischnic mischnic merged commit 8cfc9c7 into v2 Mar 18, 2024
15 of 16 checks passed
@mischnic mischnic deleted the resolver-diagnostics-empty-array branch March 21, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcompiles mattcompiles mattcompiles approved these changes

@lettertwo lettertwo Awaiting requested review from lettertwo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mischnic @mattcompiles