Ignore invalid package.json fields #10053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be clear, this isn't the same as the default value - |
@ljharb No, that's incorrect. Node falls back to index.js when
Here's a small example to prove it. Run |
|
fair enough, thanks for keeping me honest :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10051
Some popular packages started putting invalid values like
"main": falsein their package.jsons causing serde to fail to parse. See es-shims/dunder-proto#2 and es-shims/math-intrinsics#2 for example. This uses a custom serde deserializer to ignore errors and use the default value instead.