chore: update core to 0.19, api to rc0 #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flarna
reviewed
Apr 22, 2021
dyladan
commented
Apr 22, 2021
| [FaasAttribute.FAAS_EXECUTION]: context.awsRequestId, | ||
| [FaasAttribute.FAAS_ID]: context.invokedFunctionArn, | ||
| [SemanticAttributes.FAAS_EXECUTION]: context.awsRequestId, | ||
| 'faas.id': context.invokedFunctionArn, |
There was a problem hiding this comment.
faas.id is used as a span attribute here, but should be a resource attribute. I left it here to make this PR as small as possible while passing and changing no behavior. I will create a follow up bug to fix this.
Codecov Report
@@ Coverage Diff @@
## main #440 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 21 21
Lines 695 695
Branches 95 95
=======================================
Hits 668 668
Misses 27 27 |
Flarna
approved these changes
Apr 22, 2021
|
exciting! |
naseemkullah
approved these changes
Apr 22, 2021
lizthegrey
approved these changes
Apr 22, 2021
vmarchaud
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now I am keeping the API dependency where it is and updating it to latest. a follow up will move it to peer deps.