-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate profiling pdata #10195
Generate profiling pdata #10195
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10195 +/- ##
==========================================
+ Coverage 91.99% 92.52% +0.53%
==========================================
Files 361 387 +26
Lines 16982 18191 +1209
==========================================
+ Hits 15622 16831 +1209
Misses 1020 1020
Partials 340 340 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This has to wait until contrib-tests work again (should happen soon)
cc @open-telemetry/collector-approvers last call to review this one |
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This generates the pdata for profiles. <!-- Issue number if applicable --> #### Link to tracking issue Last step of open-telemetry#10109. <!--Describe what testing was performed and which tests were added.--> #### Testing The generated code is unit-tested by generated tests. cc @mx-psi --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This generates the pdata for profiles. <!-- Issue number if applicable --> #### Link to tracking issue Last step of open-telemetry#10109. <!--Describe what testing was performed and which tests were added.--> #### Testing The generated code is unit-tested by generated tests. cc @mx-psi --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Description
This generates the pdata for profiles.
Link to tracking issue
Last step of #10109.
Testing
The generated code is unit-tested by generated tests.
cc @mx-psi