Refactor TestAssert: Replace ToArray()[0] with First() for efficiency. #4888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
stevenaw
approved these changes
Nov 23, 2024
There was a problem hiding this comment.
Looks great to me, and all the tests are passing. Thanks for spotting this and for your contribution to fixing it @Saurav-shres
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the TestAssert class, specifically the IsRunnable(Type type, string name, ResultState resultState) method. The change replaces the use of ToArray()[0] with the more efficient First() method from LINQ. This improves the performance by eliminating unnecessary array allocation and directly accessing the first element in the collection.
Fixes #4886