BUG: weighted nanpercentile, nanquantile and multi-dim q #26582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
changed the title
|
Linter failures are real. I unfortunately don't have time to understand the code to give you a proper code review right now. |
ogrisel
reviewed
Jun 13, 2024
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
|
I pushed some changes, to simplify the logic with moveaxes and add tests for multi-dimensional inputs. The problem if you add tests... is that you find the other bugs in the old code paths and need to fix them too. Multi-dimensional |
seberg
approved these changes
Jun 14, 2024
seberg
changed the title
q
seberg
changed the title
q
|
Thanks @lorentzenchr and reviewers. |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Jun 15, 2024
* TST add test_nan_value_with_weight * FIX weighted nanquantile * CLN appease linter * Update numpy/lib/tests/test_nanfunctions.py Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> * Simplify code, expand old and add new ndim test with weights * BUG: Expand test and fix multi-dimensional q in the normal path... --------- Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Sebastian Berg <sebastianb@nvidia.com>
ArvidJB
pushed a commit
to ArvidJB/numpy
that referenced
this pull request
Nov 1, 2024
* TST add test_nan_value_with_weight * FIX weighted nanquantile * CLN appease linter * Update numpy/lib/tests/test_nanfunctions.py Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> * Simplify code, expand old and add new ndim test with weights * BUG: Expand test and fix multi-dimensional q in the normal path... --------- Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Sebastian Berg <sebastianb@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26455.
Hint: The solution is no beauty, but it does seem to do it's job. The whole
nanpercentileseems convoluted given that it could rely more onpercentile.