New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix def can be undefined if the type is missing #4997

Merged

knolleary merged 1 commit into node-red:master from GogoVega:fix-def-import

Dec 17, 2024

Contributor

GogoVega commented Dec 17, 2024 •

edited

Loading

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Proposed changes

Fixes https://discourse.nodered.org/t/to-import-a-flow-without-dashboard-installed/93963.
Introduced by #4808.

def can be undefined. The default definition is added directly to the node, so node._def must be used instead.

Checklist

I have read the contribution guidelines
For non-bugfix PRs, I have discussed this change on the forum/slack team.
I have run npm run test to verify the unit tests pass
I have added suitable unit tests to cover the new/changed functionality


          Fix def can be undefined if the type is missing

c689571

knolleary merged commit ed0399b into node-red:master

4 checks passed

GogoVega deleted the fix-def-import branch

December 17, 2024 17:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet