Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: e2e #11737

Merged
merged 51 commits into from
Sep 9, 2024
Merged

chore: e2e #11737

merged 51 commits into from
Sep 9, 2024

Conversation

ThangHuuVu
Copy link
Member

@ThangHuuVu ThangHuuVu commented Aug 31, 2024 •
edited
Loading

  • Removed the cache steps, as they are not recommended in the Playwright docs.
  • Move the tests under next-auth which I think makes more sense, since the e2e tests are ran against a next.js app
  • Have to disable a test (Signout). The session is still shown in the UI, this could be an issue.

@vercel Vercel
Copy link

vercel bot commented Aug 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 4:32pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 4:32pm
proxy ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 4:32pm

@codecov Codecov
Copy link

codecov bot commented Aug 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.35%. Comparing base (18b5955) to head (e7786ae).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11737   +/-   ##
=======================================
  Coverage   39.35%   39.35%           
=======================================
  Files         185      185           
  Lines       29346    29346           
  Branches     1264     1264           
=======================================
  Hits        11549    11549           
  Misses      17797    17797

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

Broken Link Checker

0 broken links found. Links organised below by source page, or page where they were found.

@socket-security Socket Security
Copy link

socket-security bot commented Sep 9, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@actions/core@1.10.1 environment, filesystem Transitive: network +1 149 kB thboop
npm/@auth/solid-start@0.12.2 environment Transitive: network +4 2.37 MB balazsorban
npm/@solidjs/meta@0.28.7 None 0 20.4 kB ryansolid
npm/@solidjs/router@0.6.0 None 0 87.6 kB ryansolid
npm/autoprefixer@10.4.20 environment Transitive: filesystem, shell +7 2.58 MB ai
npm/postcss@8.4.44 environment, filesystem +1 205 kB ai
npm/solid-js@1.8.22 None +2 2.01 MB ryansolid
npm/solid-start-node@0.2.32 environment, filesystem Transitive: eval, network, shell, unsafe +43 9.42 MB ryansolid
npm/solid-start-vercel@0.2.32 filesystem, shell Transitive: environment, eval, network, unsafe +67 9.24 MB ryansolid
npm/solid-start@0.2.32 Transitive: environment, eval, filesystem, network, shell, unsafe +268 44.3 MB ryansolid
npm/tailwindcss@3.4.10 environment, filesystem Transitive: shell, unsafe +19 11.8 MB adamwathan
npm/typescript@5.2.2 None 0 40.6 MB typescript-bot
npm/vite@3.2.10 environment, eval, filesystem, network, shell, unsafe +3 10.1 MB vitebot
npm/zod@3.23.8 None 0 667 kB colinmcd94

View full report↗︎

@ThangHuuVu
Revert "tweak commands"
e7786ae 
This reverts commit 8855517.
@ThangHuuVu ThangHuuVu merged commit 8c52012 into main Sep 9, 2024
14 of 15 checks passed
@ThangHuuVu ThangHuuVu deleted the chore/e2e-optimize branch September 9, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndom91 ndom91 ndom91 left review comments

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44 balazsorban44 is a code owner

@ubbe-xyz ubbe-xyz Awaiting requested review from ubbe-xyz ubbe-xyz is a code owner

Assignees
No one assigned
Labels
next-auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThangHuuVu @ndom91 @balazsorban44