-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
after nest build the nest-cli defined assets are only placed into the expected outdir directories if watchAssets is true #2687
Comments
Why if you change this {"include": "../certs/*", "outDir": "./dist/certs1"},
{"include": "../certs", "outDir": "./dist/certs2"} to this {"include": "../certs/*", "outDir": "./dist/certs1"},
{"include": "../certs/*", "outDir": "./dist/certs2"} |
Thanks, this works like expected with the {"include": "../certs", "outDir": "./dist/certs2"} After upgrade to nestjs 10 we figured out, that the behavior is different. All our certificates where not copied anymore. But the main issue/confusion persist. Why nestcli produces different outputs depending on the flag |
I just did this upgrade today and it took a while to also uncover this. Previously Was this change in behaviour intentional or documented? I couldn't find anything. |
This should be fixed in 10.4.3 |
Hi @kamilmysliwiec , i increased the nest-cli version to 10.4.3 and the issue still persist. The behaviour is still different. You can try it out with the steps to reproduce from my initial post. Best regards |
Thanks for the quick feedback @andreasvh-conceto. It seems that these are 2 different bugs and only one of them was solved in the new release. I just pushed a quick hotfix and published a new version (10.4.4). Let me know if you're still running into this issue. |
Hi @kamilmysliwiec , thank you very much. It is working now as expected! :) Best regards :) |
Is there an existing issue for this?
Current behavior
After
npm run build
the files are not placed in the expected directories. Only ifwatchAssets
is set to true the files are copied to their desired outdirs.Minimum reproduction code
https://github.com/andreasvh-conceto/nestcli-reproduce-asset-include
Steps to reproduce
git clone git@github.com:andreasvh-conceto/nestcli-reproduce-asset-include.git
cd nestcli-reproduce-asset-include
npm i
nest-cli.json
to check expectationsnpm run build
and look inside the dist folderwatchAssets: true
in thenest-cli.json
npm run build
Expected behavior
If
watchAssets
is not set or is set to true/false will not have an effect on the outdir directory structure after annpm run build
. The files/directories defined innest-cli.json
will be copied as expected to their outdirs.Package version
10.4.2
NestJS version
10.3.10
Node.js version
v20.12.1
In which operating systems have you tested?
Other
Could be related to: #2677
Hardware Overview:
Model Name: MacBook Pro
Model Identifier: MacBookPro17,1
Model Number: Z11C000JAD/A
Chip: Apple M1
Total Number of Cores: 8 (4 performance and 4 efficiency)
Memory: 16 GB
System Firmware Version: 10151.121.1
OS Loader Version: 10151.121.1
Serial Number (system): FVFFF2NPQ05P
Hardware UUID: F8CA8278-2342-568C-AF29-5A89497A28A4
Provisioning UDID: 00008103-000E2098143A001E
Activation Lock Status: Disabled
The text was updated successfully, but these errors were encountered: