-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Fix Regular Expression Denial of Service (ReDoS) vulnerabilities #44627
Conversation
Netlify deploy previewhttps://deploy-preview-44627--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment above the changed regular expressions would be enough, I wouldn't add tests specifically for a DOS attack. We could add a link to a example of how it can be tested.
Modified as described above, removed the tests and added comment descriptions, not sure how you want to add the link? I think the 4 PoCs in issue #44078 are good enough as examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SuperMaxine I've also added a link to the issue as a comment as well, thanks again for working on this ~
Fixes #44078