[docs-infra] Correctly flatten the pages tree #44514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-44514--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
docs-infra-fix-navigation
branch
3 times, most recently
from
fe9944a to
313404f
Compare
oliviertassinari
force-pushed
the
docs-infra-fix-navigation
branch
from
313404f to
ab58392
Compare
oliviertassinari
changed the title
alexfauquette
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This logic has been buggy for a long time, we were lucky up until now to not hit it, but with mui/mui-x#15014, we started to see it:
This happens because in MUI X v8, we added
subheader, breaking the previous heuristic: if there is a single child, then this child is a leaf. Nop, not true ever since we support subheaders.Preview: https://mui.com/material-ui/getting-started/. On Material UI, nothing should change.