Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pom scope for Scala projects #1531

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Fix pom scope for Scala projects #1531

merged 2 commits into from
Oct 17, 2024

Conversation

rozza
Copy link
Member

@rozza rozza commented Oct 16, 2024

Required the api dependency method from the java-library plugin. Now the scope is compile instead of runtime.

JAVA-5647

@rozza
Fix pom scope for Scala projects
01f9277 
Required the `api` dependency method from the `java-library` plugin.
Now the scope is `compile` instead of runtime.

JAVA-5647
@rozza rozza requested review from a team and NathanQingyangXu and removed request for a team October 16, 2024 09:08
@rozza
Copy link
Member Author

rozza commented Oct 16, 2024

To check the generated poms run:

./gradlew bson-scala:publishToMavenLocal driver-scala:publishToMavenLocal

Then the built jars & poms will then be in your local maven repository: ~/.m2/repository/org/mongodb/scala.

The mongo-scala-bson_2.13 pom should have the bson library scoped to compile.
The mongo-scala-driver_2.13 pom should have the scala bson library as well as the reactive streams driver scoped to compile.

NathanQingyangXu
NathanQingyangXu approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@NathanQingyangXu NathanQingyangXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rozza rozza merged commit 8a4ce4f into mongodb:main Oct 17, 2024
7 of 8 checks passed
@rozza rozza deleted the JAVA-5647 branch October 17, 2024 13:12
rozza added a commit to rozza/mongo-java-driver that referenced this pull request Oct 17, 2024
@rozza
Fix pom scope for Scala projects (mongodb#1531)
ca1f66c 
Required the `api` dependency method from the `java-library` plugin.
Now the scope is `compile` (api) instead of `runtime` (implementation).

JAVA-5647
rozza added a commit to rozza/mongo-java-driver that referenced this pull request Oct 17, 2024
@rozza
Fix pom scope for Scala projects (mongodb#1531)
f2bf29a 
Required the `api` dependency method from the `java-library` plugin.
Now the scope is `compile` (api) instead of `runtime` (implementation).

JAVA-5647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanQingyangXu NathanQingyangXu NathanQingyangXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rozza @NathanQingyangXu