fix(1308): Handle nullable complex and nested value classes #1314
+121
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks for looking into this! I'm both amazed and scared at the recursive implementation of |
|
Wow, that looks simple yet complex, nice one! Thanks so much for looking! |
|
Hi @Raibaz, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1308
Problem:
The PR introduced a regression when a function is returning a nullable value class with a property that is not primitive and also in cases of a nested value class where the innermost property is not a primitive. In these cases we should be using the boxed value instead of the unboxed value.
Implementation:
The implementation was adjusted based on the following.