-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mockito-inline dependency after upgrade 5.0.0 #2877
Comments
Good question. For explicitness, you can still depend on mockito-inline, but behaviourally it will have no effect. It would be similar if you would use |
I would also say that we remove it. Typically, you'd depend on standard Mockito but we wanted to give a simple pom choice to switch the default as it normally is related to a project's setup. Mockito core contains all code for all mock-makers, but its a configuration file that defines what mock maker is used. |
Okay, in that case we should remove Line 6 in 91223f8
|
As of Mockito 5.0.0 the default mockmaker was switched to `mockito-inline`: https://github.com/mockito/mockito/releases/tag/v5.0.0. More details and discussions: mockito/mockito#2877.
Nice that the removal took the price here, since i also think this makes life easier for all sides IMHO. It is easier to maintain (less packages to publish), easier to upgrade for the user and easier in the dependency handling / docs too. Thank you for working on that @valfirst ! |
What about performance issues. Bytecode injection is very slow compared to subclass. Why is this not mentioned si the changelog ? |
The tests will remain in the new `inlineTest` subproject. Fixes #2877
Mockito-inline was removed as stated here: mockito/mockito#2877
- mockito-inline 디펜던시 제거 mockito 5.3.0 부터 mocktio-core에 통합된 것 같다. > * https://github.com/mockito/mockito/releases/tag/v5.3.0 > * mockito/mockito#2877
- mockito-inline 디펜던시 제거 mockito 5.3.0 부터 mocktio-core에 통합된 것 같다. > * https://github.com/mockito/mockito/releases/tag/v5.3.0 > * mockito/mockito#2877
- mockito-inline 디펜던시 제거 mockito 5.3.0 부터 mocktio-core에 통합된 것 같다. > * https://github.com/mockito/mockito/releases/tag/v5.3.0 > * mockito/mockito#2877
I tried :
and
But both cases I'm facing issue like:
My code is:
where Any guidance will be helpful. Thanks. |
After reading that mockito switched to mockito-inline by default (with 5.0.0) i expected either mockito-core to have a mockito-inline dependency, or mockito-inline has been merged into mockito-core.
Interestingly neither of this is the case (since mockito-inline has a 5.0.0 release and no mockito-inline transitive dependency is found in https://mvnrepository.com/artifact/org.mockito/mockito-core/5.0.0 )
The concrete question is, how should we go about the current explicit dependency on mockito-inline. Should it be removed with 5.0.0 or should it stay?
The text was updated successfully, but these errors were encountered: