hack: do not cache rootless stage on release #5302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was curious "why cache at all?" but recalled we had a discussion about that on the other PR; #3543 (review)
Still curious though if we could somehow have a workflow where the build is run and tested, then if everything is successful, the images (and repo?) tagged and pushed without rebuilding, But perhaps provenance won't allow such a workflow though (moby/moby#48391) 🤔 |
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
dockerfile-rootless-cache
branch
from
d908ae3 to
b0e8368
Compare
crazy-max
changed the title
thompson-shaun
previously approved these changes
Sep 5, 2024
tonistiigi
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to #3543
fixes #5279
We got some false-positive reported in security tab when rootless image is analyzed by Docker Scout because alpine packages are cached. With this change we make sure this stage is not cached on release.
cc @cdupuis