fix(recorder): allow clearing when recording is disabled #33821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
mxschmitt
reviewed
Dec 3, 2024
|
Implemented the " |
Test results for "tests 1"37203 passed, 650 skipped Merge workflow run. |
dgozman
approved these changes
Dec 6, 2024
dgozman
pushed a commit
to dgozman/playwright
that referenced
this pull request
Dec 6, 2024
…rding is disabled
dgozman
added a commit
that referenced
this pull request
Dec 6, 2024
…disabled (#33900) Co-authored-by: Simon Knott <info@simonknott.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33802. This regressed in #32880, which aimed to unflake a specific test with a race condition around the
mainFrame.instrumentation.onAfterCallcallback. As a side effect, it broke clearing a disabled recorder. The fix is to move thethis._enabledcheck up the call chain, so it only impacts the race condition.