-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning up the build process #2857
Comments
that all makes sense! Looking forward to your PR! |
Ah man yeah I'm hoping most of the build stuff we have is re-usable - it can use the I was actually working on a branch to clean up the pipeline which I'll put up now so you can at least have a look at it, maybe it's a reasonable interim step (which would make swapping for |
^ WIP branch added above, hey at least the tests are green. |
I think betting against the Astral guys long term is probably going to be a bad idea :D I might start playing with I know they also have rye which uses |
I've been eyeing up
It's obviously early days, and they will hopefully support this sort of tinkering in the future - but in the meantime for switching we'd need to work a bit differently with respect to the versioning (storing this in source control or strictly using tags) and hooks (multi-step build process for the caller) |
For now, I'm calling this done 🥳 |
Yes, the tagged build worked great as well! Thanks 🙏 |
Prerequisites
Description
Overview
After v1 of the migration to the
poetry
build system was completed, some kruft was left over and can now be tackled individually, and with care.I'm using this issue to catalogue the things that should ideally be cleaned up and to contain discussion as well.
poetry
installation in the pipeline to https://github.com/snok/install-poetrypoetry x
commands in the GH Actions pipelinevenv
steps in build are doing what they're supposed to doThe text was updated successfully, but these errors were encountered: